[GEDI] [PATCH v3 00/25] error: auto propagated local_err

[no-reply at patchew.org]

Patchew URL: https://patchew.org/QEMU/20190924200902.4703-1-vsementsov@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190924200902.4703-1-vsementsov at virtuozzo.com
Subject: [PATCH v3 00/25] error: auto propagated local_err

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
2821824 PVRDMA: Fix error_append_hint usage
4fed9bd nbd: Fix error_append_hint usage
4dd593b Sockets: Fix error_append_hint usage
4b51e60 Migration: Fix error_append_hint usage
8badd1e QOM: Fix error_append_hint usage
cee12d7 cmdline: Fix error_append_hint usage
9ee000d chardev: Fix error_append_hint usage
9b82769 block: Fix error_append_hint usage
2680a9c virtio-9p: Fix error_append_hint usage
9563cc0 virtio: Fix error_append_hint usage
eaf3c5f VFIO: Fix error_append_hint usage
5a70d12 USB: Fix error_append_hint usage
a7307a2 SCSI: Fix error_append_hint usage
38ab236 PCI: Fix error_append_hint usage
1e3f98e SmartFusion2: Fix error_append_hint usage
4b06bcc arm: Fix error_append_hint usage
1e194b4 PowerPC TCG CPUs: Fix error_append_hint usage
16f7be8 ARM TCG CPUs: Fix error_append_hint usage
38baa0a s390: Fix error_append_hint usage
e596c72 python: add commit-per-subsystem.py
c82b758 scripts: add coccinelle script to fix error_append_hint usage
4c37d5c error: auto propagated local_err
1f5d983 net/net: fix local variable shadowing in net_client_init
118f617 hw/core/loader-fit: fix freeing errp in fit_load_fdt
2493069 errp: rename errp to errp_in where it is IN-argument

=== OUTPUT BEGIN ===
1/25 Checking commit 2493069b7603 (errp: rename errp to errp_in where it is IN-argument)
2/25 Checking commit 118f61787279 (hw/core/loader-fit: fix freeing errp in fit_load_fdt)
3/25 Checking commit 1f5d98328d6c (net/net: fix local variable shadowing in net_client_init)
4/25 Checking commit 4c37d5c6d228 (error: auto propagated local_err)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#69: FILE: include/qapi/error.h:355:
+#define ERRP_FUNCTION_BEGIN() \
+g_auto(ErrorPropagator) __auto_errp_prop = {.errp = errp}; \
+errp = ((errp == NULL || *errp == error_fatal) ? \
+    &__auto_errp_prop.local_err : errp)

total: 1 errors, 0 warnings, 41 lines checked

Patch 4/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/25 Checking commit c82b758af1da (scripts: add coccinelle script to fix error_append_hint usage)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 25 lines checked

Patch 5/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/25 Checking commit e596c720393c (python: add commit-per-subsystem.py)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100755

total: 0 errors, 1 warnings, 69 lines checked

Patch 6/25 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/25 Checking commit 38baa0a318a0 (s390: Fix error_append_hint usage)
8/25 Checking commit 16f7be86eeb1 (ARM TCG CPUs: Fix error_append_hint usage)
9/25 Checking commit 1e194b48e97b (PowerPC TCG CPUs: Fix error_append_hint usage)
10/25 Checking commit 4b06bccfe947 (arm: Fix error_append_hint usage)
11/25 Checking commit 1e3f98eb12d0 (SmartFusion2: Fix error_append_hint usage)
12/25 Checking commit 38ab2364f44b (PCI: Fix error_append_hint usage)
13/25 Checking commit a7307a29159e (SCSI: Fix error_append_hint usage)
14/25 Checking commit 5a70d127c9fc (USB: Fix error_append_hint usage)
15/25 Checking commit eaf3c5f855c8 (VFIO: Fix error_append_hint usage)
16/25 Checking commit 9563cc0b6e37 (virtio: Fix error_append_hint usage)
17/25 Checking commit 2680a9ca88fa (virtio-9p: Fix error_append_hint usage)
18/25 Checking commit 9b8276961550 (block: Fix error_append_hint usage)
19/25 Checking commit 9ee000da2508 (chardev: Fix error_append_hint usage)
20/25 Checking commit cee12d7c8697 (cmdline: Fix error_append_hint usage)
21/25 Checking commit 8badd1ec04da (QOM: Fix error_append_hint usage)
22/25 Checking commit 4b51e60a1e83 (Migration: Fix error_append_hint usage)
23/25 Checking commit 4dd593b9c7df (Sockets: Fix error_append_hint usage)
24/25 Checking commit 4fed9bd83a77 (nbd: Fix error_append_hint usage)
25/25 Checking commit 2821824d98bf (PVRDMA: Fix error_append_hint usage)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190924200902.4703-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel at redhat.com