[GEDI] [PATCH v3 18/25] block: Fix error_append_hint usage
eblake at redhat.com
Tue Sep 24 21:03:59 UTC 2019
On 9/24/19 3:08 PM, Vladimir Sementsov-Ogievskiy wrote:
> If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro.
> Otherwise hint will not be appended in case of errp == &fatal_err
> (program will exit before error_append_hint() call). Fix such cases.
> This commit (together with its neighbors) was generated by
> git grep -l 'error_append_hint(errp' | while read f; do \
> spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \
> --in-place $f; done
> and then
> ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)"
> (auto-msg was a file with this commit message)
Your automation is cool!
> Still, for backporting it may be more comfortable to use only the first
> command and then do one huge commit.
> Reported-by: Greg Kurz <groug at kaod.org>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov at virtuozzo.com>
> block/backup.c | 1 +
> block/dirty-bitmap.c | 1 +
> block/file-posix.c | 3 +++
> block/gluster.c | 2 ++
> block/qcow.c | 1 +
> block/qcow2.c | 1 +
> block/vhdx-log.c | 1 +
> block/vpc.c | 1 +
> 8 files changed, 11 insertions(+)
$ git grep -p 'error_append_hint(errp' block/ | grep '\.c=' | wc -l
produces 11 hits, very nicely matching up with your patch.
Reviewed-by: Eric Blake <eblake at redhat.com>
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 488 bytes
Desc: OpenPGP digital signature
More information about the integration