[GEDI] [RFC v5 025/126] scripts: add coccinelle script to use auto propagated errp

[Vladimir Sementsov-Ogievskiy]

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov at virtuozzo.com>
---

CC: Gerd Hoffmann <kraxel at redhat.com>
CC: "Gonglei (Arei)" <arei.gonglei at huawei.com>
CC: Eduardo Habkost <ehabkost at redhat.com>
CC: Igor Mammedov <imammedo at redhat.com>
CC: Laurent Vivier <lvivier at redhat.com>
CC: Amit Shah <amit at kernel.org>
CC: Kevin Wolf <kwolf at redhat.com>
CC: Max Reitz <mreitz at redhat.com>
CC: John Snow <jsnow at redhat.com>
CC: Ari Sundholm <ari at tuxera.com>
CC: Pavel Dovgalyuk <pavel.dovgaluk at ispras.ru>
CC: Paolo Bonzini <pbonzini at redhat.com>
CC: Stefan Hajnoczi <stefanha at redhat.com>
CC: Fam Zheng <fam at euphon.net>
CC: Stefan Weil <sw at weilnetz.de>
CC: Ronnie Sahlberg <ronniesahlberg at gmail.com>
CC: Peter Lieven <pl at kamp.de>
CC: Eric Blake <eblake at redhat.com>
CC: "Denis V. Lunev" <den at openvz.org>
CC: Markus Armbruster <armbru at redhat.com>
CC: Alberto Garcia <berto at igalia.com>
CC: Jason Dillaman <dillaman at redhat.com>
CC: Wen Congyang <wencongyang2 at huawei.com>
CC: Xie Changlong <xiechanglong.d at gmail.com>
CC: Liu Yuan <namei.unix at gmail.com>
CC: "Richard W.M. Jones" <rjones at redhat.com>
CC: Jeff Cody <codyprime at gmail.com>
CC: "Marc-André Lureau" <marcandre.lureau at redhat.com>
CC: "Daniel P. Berrangé" <berrange at redhat.com>
CC: Richard Henderson <rth at twiddle.net>
CC: Greg Kurz <groug at kaod.org>
CC: "Michael S. Tsirkin" <mst at redhat.com>
CC: Marcel Apfelbaum <marcel.apfelbaum at gmail.com>
CC: Beniamino Galvani <b.galvani at gmail.com>
CC: Peter Maydell <peter.maydell at linaro.org>
CC: "Cédric Le Goater" <clg at kaod.org>
CC: Andrew Jeffery <andrew at aj.id.au>
CC: Joel Stanley <joel at jms.id.au>
CC: Andrew Baumann <Andrew.Baumann at microsoft.com>
CC: "Philippe Mathieu-Daudé" <philmd at redhat.com>
CC: Antony Pavlov <antonynpavlov at gmail.com>
CC: Jean-Christophe Dubois <jcd at tribudubois.net>
CC: Peter Chubb <peter.chubb at nicta.com.au>
CC: Subbaraya Sundeep <sundeep.lkml at gmail.com>
CC: Eric Auger <eric.auger at redhat.com>
CC: Alistair Francis <alistair at alistair23.me>
CC: "Edgar E. Iglesias" <edgar.iglesias at gmail.com>
CC: Stefano Stabellini <sstabellini at kernel.org>
CC: Anthony Perard <anthony.perard at citrix.com>
CC: Paul Durrant <paul at xen.org>
CC: Paul Burton <pburton at wavecomp.com>
CC: Aleksandar Rikalo <arikalo at wavecomp.com>
CC: Chris Wulff <crwulff at gmail.com>
CC: Marek Vasut <marex at denx.de>
CC: David Gibson <david at gibson.dropbear.id.au>
CC: Cornelia Huck <cohuck at redhat.com>
CC: Halil Pasic <pasic at linux.ibm.com>
CC: Christian Borntraeger <borntraeger at de.ibm.com>
CC: "Hervé Poussineau" <hpoussin at reactos.org>
CC: Xiao Guangrong <xiaoguangrong.eric at gmail.com>
CC: Aurelien Jarno <aurelien at aurel32.net>
CC: Aleksandar Markovic <amarkovic at wavecomp.com>
CC: Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk>
CC: Jason Wang <jasowang at redhat.com>
CC: Laszlo Ersek <lersek at redhat.com>
CC: Yuval Shaia <yuval.shaia at oracle.com>
CC: Palmer Dabbelt <palmer at sifive.com>
CC: Sagar Karandikar <sagark at eecs.berkeley.edu>
CC: Bastian Koppelmann <kbastian at mail.uni-paderborn.de>
CC: David Hildenbrand <david at redhat.com>
CC: Thomas Huth <thuth at redhat.com>
CC: Eric Farman <farman at linux.ibm.com>
CC: Matthew Rosato <mjrosato at linux.ibm.com>
CC: Hannes Reinecke <hare at suse.com>
CC: Michael Walle <michael at walle.cc>
CC: Artyom Tarasenko <atar4qemu at gmail.com>
CC: Stefan Berger <stefanb at linux.ibm.com>
CC: Samuel Thibault <samuel.thibault at ens-lyon.org>
CC: Alex Williamson <alex.williamson at redhat.com>
CC: Tony Krowiak <akrowiak at linux.ibm.com>
CC: Pierre Morel <pmorel at linux.ibm.com>
CC: Michael Roth <mdroth at linux.vnet.ibm.com>
CC: Hailiang Zhang <zhang.zhanghailiang at huawei.com>
CC: Juan Quintela <quintela at redhat.com>
CC: "Dr. David Alan Gilbert" <dgilbert at redhat.com>
CC: Luigi Rizzo <rizzo at iet.unipi.it>
CC: Giuseppe Lettieri <g.lettieri at iet.unipi.it>
CC: Vincenzo Maffione <v.maffione at gmail.com>
CC: Jan Kiszka <jan.kiszka at siemens.com>
CC: Anthony Green <green at moxielogic.com>
CC: Stafford Horne <shorne at gmail.com>
CC: Guan Xuetao <gxt at mprc.pku.edu.cn>
CC: Max Filippov <jcmvbkbc at gmail.com>
CC: qemu-block at nongnu.org
CC: integration at gluster.org
CC: sheepdog at lists.wpkg.org
CC: qemu-arm at nongnu.org
CC: xen-devel at lists.xenproject.org
CC: qemu-ppc at nongnu.org
CC: qemu-s390x at nongnu.org
CC: qemu-riscv at nongnu.org

 scripts/coccinelle/auto-propagated-errp.cocci | 118 ++++++++++++++++++
 1 file changed, 118 insertions(+)
 create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci

diff --git a/scripts/coccinelle/auto-propagated-errp.cocci b/scripts/coccinelle/auto-propagated-errp.cocci
new file mode 100644
index 0000000000..d9731620aa
--- /dev/null
+++ b/scripts/coccinelle/auto-propagated-errp.cocci
@@ -0,0 +1,118 @@
+ at rule0@
+// Add invocation to errp-functions where necessary
+identifier fn, local_err;
+symbol errp;
+@@
+
+ fn(..., Error **errp, ...)
+ {
++   ERRP_AUTO_PROPAGATE();
+    <+...
+(
+    error_append_hint(errp, ...);
+|
+    error_prepend(errp, ...);
+|
+    Error *local_err = NULL;
+)
+    ...+>
+ }
+
+@@
+// Drop doubled invocation
+identifier rule0.fn;
+@@
+
+ fn(...)
+{
+-   ERRP_AUTO_PROPAGATE();
+    ERRP_AUTO_PROPAGATE();
+    ...
+}
+
+ at rule1@
+// Drop local_err
+identifier fn, local_err;
+symbol errp;
+@@
+
+ fn(..., Error **errp, ...)
+ {
+     <...
+-    Error *local_err = NULL;
+     ...>
+ }
+
+@@
+// Handle pattern with goto, otherwise we'll finish up
+// with labels at function end which will not compile.
+identifier rule1.fn;
+identifier rule1.local_err;
+identifier OUT;
+@@
+
+ fn(...)
+ {
+     <...
+-    goto OUT;
++    return;
+     ...>
+- OUT:
+-    error_propagate(errp, local_err);
+ }
+
+@@
+identifier rule1.fn;
+identifier rule1.local_err;
+@@
+
+ fn(...)
+ {
+     <...
+(
+-    error_free(local_err);
+-    local_err = NULL;
++    error_free_errp(errp);
+|
+-    error_free(local_err);
++    error_free_errp(errp);
+|
+-    error_report_err(local_err);
++    error_report_errp(errp);
+|
+-    warn_report_err(local_err);
++    warn_report_errp(errp);
+|
+-    error_propagate_prepend(errp, local_err,
++    error_prepend(errp,
+                              ...);
+|
+-    error_propagate(errp, local_err);
+)
+     ...>
+ }
+
+@@
+identifier rule1.fn;
+identifier rule1.local_err;
+@@
+
+ fn(...)
+ {
+     <...
+(
+-    &local_err
++    errp
+|
+-    local_err
++    *errp
+)
+     ...>
+ }
+
+@@
+symbol errp;
+@@
+
+- *errp != NULL
++ *errp
-- 
2.21.0