[Gluster-users] [Gluster-devel] Incorrect exit code from mount.glusterfs

[Justin Clift]

On 08/04/2014, at 12:20 PM, Deepak Shetty wrote:
> On Tue, Apr 8, 2014 at 4:20 PM, Niels de Vos <ndevos at redhat.com> wrote:
> On Tue, Apr 08, 2014 at 03:50:42PM +0530, Deepak Shetty wrote:
> > Hi All,
> >    I am wondering if this I am the only one seeing this or there are enuf
> > reasons why mount.glusterfs returns 0 (which means success) as the exit
> > code for error cases ?
> > Bcos of this cinder (openstack service) code is misled as it thinks
> > mounting glusterfs volume on already mounted volume is successfull and
> > never gets into the warning/error flow!
> > (Not to mention that i spent 1+ days debugging and reaching that
> > conclusion!!!)
> 
> This should definitely get fixed in the mount.glusterfs shell script.
> The correct return values are listed in 'man 8 mount'. Please file a bug
> for this:
> - https://bugzilla.redhat.com/enter_bug.cgi?product=GlusterFS&component=scripts
> 
> There was already a similar bug opened and in NEW state since Nov 2013
> https://bugzilla.redhat.com/show_bug.cgi?id=1031973
> 
> I added my comments and increased the prio and imp of that bug
> in the hope that it will be assigned and fixed :)

Effort-wise, this seems like a fairly simple fix once we determine the
correct error codes.

Sounds like it would be useful to get into 3.5.x series too.

+ Justin

--
Open Source and Standards @ Red Hat

twitter.com/realjustinclift