[Gluster-users] Fwd: Change in glusterfs[release-3.3]: cluster/afr: Preserve mtime in self-heal

[John Mark Walker]

If anyone has had issues with self-heal clobbering mtime, this is the patch to try for 3.3.

-JM 

-------- Original Message --------
Subject: Change in glusterfs[release-3.3]: cluster/afr: Preserve mtime in self-heal
From: "Pranith Kumar Karampuri (Code Review)" <root at dev.gluster.com>
To: Jeff Darcy <jdarcy at redhat.com>,Gluster Build System <jenkins at build.gluster.com>
CC: 




Hello Jeff Darcy, Gluster Build System,

I'd like you to do a code review.  Please visit

    http://review.gluster.org/4664

to review the following change.

Change subject: cluster/afr: Preserve mtime in self-heal
......................................................................

cluster/afr: Preserve mtime in self-heal

Problem:
Data self-heal may choose sink iatt to set mtimes.
This happens because after syncing of data is done
self-heal does one more xattrops/fstat to determine
sources sinks to set the inode-ctx. Since this is done
after data syncing and erase of xattrs, old source and
old sink are now sources, but the mtimes of them differ.
Old code just takes the first source from the list and
update mtimes, which could be sink before the self-heal
started.

Fix:
Set mtime from 'sources before syncing'.

Change-Id: Id769e1b99aa4f041eaee775f64cbf2c57b799723
BUG: 918437
Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
Reviewed-on: http://review.gluster.org/4658
Reviewed-by: Jeff Darcy <jdarcy at redhat.com>
Tested-by: Gluster Build System <jenkins at build.gluster.com>
---
A tests/bugs/bug-918437-sh-mtime.t
M xlators/cluster/afr/src/afr-self-heal-data.c
2 files changed, 76 insertions(+), 14 deletions(-)


  git pull ssh://git.gluster.org/glusterfs refs/changes/64/4664/1
--
To view, visit http://review.gluster.org/4664
To unsubscribe, visit http://review.gluster.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id769e1b99aa4f041eaee775f64cbf2c57b799723
Gerrit-PatchSet: 1
Gerrit-Project: glusterfs
Gerrit-Branch: release-3.3
Gerrit-Owner: Pranith Kumar Karampuri <pkarampu at redhat.com>
Gerrit-Reviewer: Gluster Build System <jenkins at build.gluster.com>
Gerrit-Reviewer: Jeff Darcy <jdarcy at redhat.com>