[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke

bugzilla at redhat.com bugzilla at redhat.com
Wed Apr 25 04:21:06 UTC 2018


--- Comment #27 from Aravinda VK <avishwan at redhat.com> ---
(In reply to Xavi Hernandez from comment #19)
> I made a mistake on one of the proposed values:
> AlignEscapedNewLinesLeft=false
> What I wanted to propose was to set it to 'true' (which matches the
> explanation I gave).

I prefer Right(`AlignEscapedNewlines=Right`), since Patch will have minimum
number of lines change on modification. For example,

#define gf_log(dom, levl, fmt...) do {                          \
                FMT_WARN (fmt);                                 \
                _gf_log (dom, __FILE__, __FUNCTION__, __LINE__, \
                         levl, ##fmt);                          \
        } while (0)

If longest line is changed then patch diff shows all of them as changed lines
in case of `AlignEscapedNewLines=Left`

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eZWnKhPOYv&a=cc_unsubscribe

More information about the Gluster-infra mailing list