[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 17 22:02:43 UTC 2018


--- Comment #13 from Jeff Darcy <jeff at pl.atyp.us> ---
IndentCaseLabels: personally I don't like indenting case labels because they
create a gap with no close brace - unless people put braces around cases, which
is a bad habit for other reasons - but I know I'm probably outvoted on that

SpaceBeforeParens: I like the space between function name and arguments. The
fact that none of the "modern" styles is not very compelling by itself (appeal
to popularity) but I'm probably outvoted there too.

AlwaysBreakAfterReturnType: Yes. That's the option I was looking for. For
people who use IDEs it probably doesn't matter, but having the function name
start at the beginning of the line is very handy for those using non-IDE
editors like vi(m). It also leaves more space for parameters, making long
parameter lists - which we tend to have - more readable.

I almost don't have an opinion on the alignment options. For much of my career
I would group the * with the type rather than the variable (i.e. PAS_Left)
because it made more intuitive sense. On one hand, it seems like most of the
world now agrees. On the other, it's not the way things are in Gluster now and
hence requires a change in habits.

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zHAKTcfHCj&a=cc_unsubscribe

More information about the Gluster-infra mailing list