[Gluster-devel] Pull Request review workflow

[Ashish Pandey]

I think it's a very good suggestion, I have faced this issue too. 
I think we should it now before we get used to of the current process :) 

--- 
Ashish 


----- Original Message -----

From: "Xavi Hernandez" <jahernan at redhat.com> 
To: "gluster-devel" <gluster-devel at gluster.org> 
Sent: Thursday, October 15, 2020 6:16:06 PM 
Subject: Re: [Gluster-devel] Pull Request review workflow 

If everyone agrees, I'll prepare a PR with the changes in rfc.sh and documentation to implement this change. 

Xavi 

On Thu, Oct 15, 2020 at 1:27 PM Ravishankar N < ravishankar at redhat.com > wrote: 






On 15/10/20 4:36 pm, Sheetal Pamecha wrote: 

<blockquote>


+1 
Just a note to the maintainers who are merging PRs to have patience and check the commit message when there are more than 1 commits in PR. 




Makes sense. 
<blockquote>


<blockquote>



<blockquote>

Another thing to consider is that rfc.sh script always does a rebase before pushing changes. This rewrites history and changes all commits of a PR. I think we shouldn't do a rebase in rfc.sh. Only if there are conflicts, I would do a manual rebase and push the changes. 


</blockquote>




</blockquote>


</blockquote>


I think we would also need to rebase if say some .t failure was fixed and we need to submit the PR on top of that, unless "run regression" always applies your PR on the latest HEAD in the concerned branch and triggers the regression. 


<blockquote>


Actually True, Since the migration to github. I have not been using ./rfc.sh and For me it's easier and cleaner. 

</blockquote>





Me as well :) -Ravi 
_______________________________________________ 

Community Meeting Calendar: 

Schedule - 
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC 
Bridge: https://bluejeans.com/441850968 




Gluster-devel mailing list 
Gluster-devel at gluster.org 
https://lists.gluster.org/mailman/listinfo/gluster-devel 


</blockquote>


_______________________________________________ 

Community Meeting Calendar: 

Schedule - 
Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC 
Bridge: https://bluejeans.com/441850968 




Gluster-devel mailing list 
Gluster-devel at gluster.org 
https://lists.gluster.org/mailman/listinfo/gluster-devel 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20201015/683537f8/attachment.html>