<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div><br></div><div>I think it's a very good suggestion, I have faced this issue too.</div><div>I think we should it now before we get used to of the current process :)<br></div><div><br></div><div>---<br></div><div>Ashish<br></div><div><br></div><div><br></div><hr id="zwchr"><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Xavi Hernandez" <jahernan@redhat.com><br><b>To: </b>"gluster-devel" <gluster-devel@gluster.org><br><b>Sent: </b>Thursday, October 15, 2020 6:16:06 PM<br><b>Subject: </b>Re: [Gluster-devel] Pull Request review workflow<br><div><br></div><div dir="ltr">If everyone agrees, I'll prepare a PR with the changes in rfc.sh and documentation to implement this change.<div><br></div><div>Xavi</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 15, 2020 at 1:27 PM Ravishankar N <<a href="mailto:ravishankar@redhat.com" target="_blank" data-mce-href="mailto:ravishankar@redhat.com">ravishankar@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" data-mce-style="margin: 0px 0px 0px 0.8ex; border-left: 1px solid #cccccc; padding-left: 1ex;"><div><p><br></p><div>On 15/10/20 4:36 pm, Sheetal Pamecha wrote:<br></div><blockquote><div dir="ltr"><div class="gmail_quote"><br><div>+1 </div><div>Just a note to the maintainers who are merging PRs to have patience and check the commit message when there are more than 1 commits in PR.</div></div></div></blockquote><p>Makes sense.</p><blockquote><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" data-mce-style="margin: 0px 0px 0px 0.8ex; border-left: 1px solid #cccccc; padding-left: 1ex;"><div dir="ltr"><div><div class="gmail_quote"><div> </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" data-mce-style="margin: 0px 0px 0px 0.8ex; border-left: 1px solid #cccccc; padding-left: 1ex;"><div dir="ltr"><div>Another thing to consider is that rfc.sh script always does a rebase before pushing changes. This rewrites history and changes all commits of a PR. I think we shouldn't do a rebase in rfc.sh. Only if there are conflicts, I would do a manual rebase and push the changes.</div><div><br></div></div></blockquote><div><br></div><div><br></div></div></div></div></blockquote></div></div></blockquote><p>I think we would also need to rebase if say some .t failure was fixed and we need to submit the PR on top of that, unless "run regression" always applies your PR on the latest HEAD in the concerned branch and triggers the regression.<br></p><br><blockquote><div dir="ltr"><div class="gmail_quote"><div><br></div><div>Actually True, Since the migration to github. I have not been using ./rfc.sh and For me it's easier and cleaner. <br></div></div></div></blockquote><p><br></p><p>Me as well :)</p>-Ravi<br></div>_______________________________________________<br> <br> Community Meeting Calendar:<br> <br> Schedule -<br> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC<br> Bridge: <a href="https://bluejeans.com/441850968" rel="noreferrer" target="_blank" data-mce-href="https://bluejeans.com/441850968">https://bluejeans.com/441850968</a><br> <br> <br> <br> <br> Gluster-devel mailing list<br> <a href="mailto:Gluster-devel@gluster.org" target="_blank" data-mce-href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br> <a href="https://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank" data-mce-href="https://lists.gluster.org/mailman/listinfo/gluster-devel">https://lists.gluster.org/mailman/listinfo/gluster-devel</a><br> <br></blockquote></div><br>_______________________________________________<br><div><br></div>Community Meeting Calendar:<br><div><br></div>Schedule -<br>Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC<br>Bridge: https://bluejeans.com/441850968<br><div><br></div><br><div><br></div><br>Gluster-devel mailing list<br>Gluster-devel@gluster.org<br>https://lists.gluster.org/mailman/listinfo/gluster-devel<br><div><br></div></div><div><br></div></div></body></html>