[Gluster-devel] Fwd: Clang-format: Update

Nigel Babu nigelb at redhat.com
Thu Jun 28 11:22:24 UTC 2018


Hello folks,

A while ago we talked about using clang-format for our codebase[1]. We
started doing several pieces of this work asynchronously. Here's an update
on the current state of affairs:

* Team agrees on a style and a config file representing the style.
This has been happening asynchronously on Github[2]. Amar, Xavi, and Jeff
-- Can we close out this discussion and have a config file in 2 weeks? If
anyone feels strongly about coding style, please participate in the
discussion now.

* Commit the coding style guide to codebase and make changes in rfc.sh to
use it.
Waiting on 1. I can do this once we have the discussion finalized.

* gluster-ant commits a single large patch for whole codebase with a
standard clang-format style.
This is waiting on the first two steps and should be trivial to accomplish.
I have access to the gluster-ant account and I can make the necessary
changes.

* Have the job ready to check the patch with the config file, on the server
side, this should be a Voting job in smoke.
The server side Jenkins job is now ready[3]. The client side rfc.sh patch
is next, but merging that change will wait on the config file being ready.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1564149#c33
[2]: https://github.com/nigelbabu/clang-format-sample/
[3]: https://review.gluster.org/#/c/20418/

-- 
nigelb
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20180628/d8585c6e/attachment.html>


More information about the Gluster-devel mailing list