[Gluster-devel] Coverity cleanup drive

[Sunny Kumar]

Hi Folks,

Thanks everyone for their participation .. we reduced almost 50%
coverity issue count.

All contributions : (only merged patches)
1. Vijay - 25 patches containing 46 coverity fixes and some of them
containing improvements
2. Shyam - 3 patches containing 9 coverity fixes and some of improvement patches
3. Amar - 2 patches containing 10 coverity fixes and some improvements patches
4.  Atin - 1 patch containing 2 coverity fixes
5. Nithya - 1 patch containing 5 coverity fixes
6. Sunil - 2 patches containing 3 coverity fixes
7. Ashish - 1 patch containing 5 coverity fixes
8. Hari - 1 patch containing 4  coverity fixes.
9. Bhumika - 8 patches containing 45 coverity fixes
10. Shwetha - 4 patches containing 5+ coverity fixes.

There were so many patches and to get them merged all of you did
tremendous job. This drive would not have been successful without
patch reviewers. (Specially Amar who reviewed almost every patches)

Special thanks to Yaniv for taking so many initiatives in effort to
reduce coverity and improve stability of overall project. (Patches are
huge in numbers so I request everyone to review them)

At last I would like to say thank you all for this great effort but
the job is not done yet we still need to bring down the coveirty count
to 0 and also have to keep an eye on newly introduced coverity.
Everyone's participation is appreciated to achieve this goal.

Thanks,
Sunny Kumar
On Tue, Aug 7, 2018 at 12:29 PM Sunny Kumar <sunkumar at redhat.com> wrote:
>
> Hello folks,
>
> We are planning to reduce coverity errors to improve upstream stability.
>
> To avoid duplicate efforts and concerns like patch review, we suggest
> following rules :-
>
> 1. Visit https://scan.coverity.com/projects/gluster-glusterfs and
> request to "Add me to project" to see all reported coverity errors.
>
> 2. Pick any error and assign to yourself in Triage -> Owner section,
> it will let others know you are owner of that error and avoid
> duplicate efforts.
> In Triage-> Ext. Reference you can post patch link.
> For example see -
> https://scan6.coverity.com/reports.htm#v42401/p10714/fileInstanceId=84384726&defectInstanceId=25600457&mergedDefectId=727233&eventId=25600457-1
>
> 3. You should pick coverity per component/file basis and fix all the
> coverity errors reported for that component/file.
> If some file has few defects it is advisable to combine errors from
> same component. This will help the reviewers to quickly review the
> patch.
> For example see -
> https://review.gluster.org/#/c/20600/.
>
> 4. Please use BUG : 789278 to send all coverity related patch and do
> not forget to mention coverity link in commit message.
> For example see-
> https://review.gluster.org/#/c/20600/.
>
> 5. After the patch is merged please make entry of coverity-ID in spreadsheet.
> https://docs.google.com/spreadsheets/d/1qZNallBF30T2w_qi0wRxzqDn0KbcYP5zshiLrYu9XyQ/edit?usp=sharing.
>
> Yes ! You can win some swags by participating in this effort if you
> meet these criteria:-
>
> a. Triage the bugs properly.
> b. Updating the sheets.
> c. More than 17 coverity fixes.
> d. Most importantly all the submitted patches should get merged by
> 25th Aug 2018.
>
> Please feel free to let us know if you have any questions,
> * Sunny - sunkumar at redhat.com
> * Karthik - ksubrahm at redhat.com
> * Bhumika -  bgoyal at redhat.com
>
> - Sunny