[Gluster-devel] Fwd: [Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke

Amar Tumballi atumball at redhat.com
Tue Apr 17 07:23:01 UTC 2018


Can we have more attention to this bug and provide inputs from your
experience in different project?

This would save us lot of time in reviewing, and also make sure our
contributors are sending code which is uniform regardless of their editor

Expectation is, we come up with an agreed .clang-format file.


---------- Forwarded message ----------
From: <bugzilla at redhat.com>
Date: Tue, Apr 17, 2018 at 12:41 PM
Subject: [Gluster-infra] [Bug 1564149] Agree upon a coding standard, and
automate check for this in smoke
To: gluster-infra at gluster.org


--- Comment #9 from Amar Tumballi <atumball at redhat.com> ---
(In reply to Nigel Babu from comment #7)
> Alright. So we have agreement that this is a good idea. How do we want to
> implement this? As a check or as a pre-commit hook?

This is a multi-step process!

0. Team agrees on a style and a config file representing the style.
1. Commit the coding style guide to codebase and make changes in rfc.sh to
2. 'gluster-ant' commits a single large patch for whole codebase with a
standard clang-format style. (This should be only changes which happened
due to
clang-format, and no other changes should be in the patch. This can crash
gerrit if we send it to review.
  -> NOTE: This change can be as big as moving gluster repo from tla to
git, as
we have now 2 repositories, 'historic' and 'glusterfs' to understand the
source of a line, if one needs 'git blame'.

3. Have the job ready to check the patch with the config file, on the server
side (along with a pre-check in rfc.sh to warn people), this should be a
job in smoke.

4. We all live happily ever after.

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/
Gluster-infra mailing list
Gluster-infra at gluster.org

Amar Tumballi (amarts)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20180417/a82d79e4/attachment.html>

More information about the Gluster-devel mailing list