<div dir="ltr">All,<div><br></div><div>Can we have more attention to this bug and provide inputs from your experience in different project?</div><div><br></div><div>This would save us lot of time in reviewing, and also make sure our contributors are sending code which is uniform regardless of their editor settings.</div><div><br></div><div>Expectation is, we come up with an agreed .clang-format file.</div><div><br></div><div>-Amar</div><div><br></div><div><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername"></b> <span dir="ltr"><<a href="mailto:bugzilla@redhat.com">bugzilla@redhat.com</a>></span><br>Date: Tue, Apr 17, 2018 at 12:41 PM<br>Subject: [Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke<br>To: <a href="mailto:gluster-infra@gluster.org">gluster-infra@gluster.org</a><br><br><br><span class=""><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1564149" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1564149</a><br>
<br>
<br>
<br>
--- Comment #9 from Amar Tumballi <<a href="mailto:atumball@redhat.com">atumball@redhat.com</a>> ---<br>
(In reply to Nigel Babu from comment #7)<br>
> Alright. So we have agreement that this is a good idea. How do we want to<br>
> implement this? As a check or as a pre-commit hook?<br>
<br>
This is a multi-step process!<br>
<br>
0. Team agrees on a style and a config file representing the style.<br>
1. Commit the coding style guide to codebase and make changes in rfc.sh to use<br>
it.<br>
2. 'gluster-ant' commits a single large patch for whole codebase with a<br>
standard clang-format style. (This should be only changes which happened due to<br>
clang-format, and no other changes should be in the patch. This can crash<br>
gerrit if we send it to review. <br>
-> NOTE: This change can be as big as moving gluster repo from tla to git, as<br>
we have now 2 repositories, 'historic' and 'glusterfs' to understand the actual<br>
source of a line, if one needs 'git blame'.<br>
<br>
3. Have the job ready to check the patch with the config file, on the server<br>
side (along with a pre-check in rfc.sh to warn people), this should be a Voting<br>
job in smoke.<br>
<br>
4. We all live happily ever after.<br>
<br>
-- <br>
You are receiving this mail because:<br>
You are on the CC list for the bug.<br>
</span>Unsubscribe from this bug <a href="https://bugzilla.redhat.com/token.cgi?t=rNXvC1NMQK&a=cc_unsubscribe" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/<wbr>token.cgi?t=rNXvC1NMQK&a=cc_<wbr>unsubscribe</a><br>
<div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
Gluster-infra mailing list<br>
<a href="mailto:Gluster-infra@gluster.org">Gluster-infra@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-infra" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-infra</a><br>
</div></div></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div>