[Gluster-devel] Suggest how to recognize the time when heal is triggered by using events

[Pranith Kumar Karampuri]

hi,
     I have a couple of comments. Gerrit is good for comments :-), so post
the patch I can ask you questions at the exact line.

need_heal_count won't be accurate because the indices in 'dirty' are being
counted as is, there can be lot of false +ves in that. So I can review a
bit more closely after I understand your requirements

It is better to have the ability to configure how frequently we need the
event about heal progress. I see that you like 10 seconds, so we can keep
that as default :-).

This is a very good use of EVENTING framework!

On Thu, Jul 6, 2017 at 11:37 AM, Taehwa Lee <alghost.lee at gmail.com> wrote:

> Thanks your response.
>
>
> I want you to review the comments and patch updated again..
>
> I think that events are needed  not only  when heal is started and
> finished but also while healing like rebalancing.
>
>
> So I’ve developed and tested it.
>
>
> Can you review the patch where is on bugzilla again?
> : https://bugzilla.redhat.com/show_bug.cgi?id=1467543
>
> Sorry to bother you :(
>
>
> After your review, I’m going to try to send it on gerrit :D
>
> Thanks in advance.
>
> Best regards
>
>
>
> -----------------------------------------
> 이 태 화
> Taehwa Lee
> Gluesys Co.,Ltd.
> alghost.lee at gmail.com
> 010-3420-6114, 070-8785-6591
> -----------------------------------------
>
> 2017. 7. 5. 오후 7:36, Pranith Kumar Karampuri <pkarampu at redhat.com> 작성:
>
> patch looks good to me. Do you want to send it on gerrit?
>
> On Wed, Jul 5, 2017 at 6:49 AM, Taehwa Lee <alghost.lee at gmail.com> wrote:
>
>> Hello, Karampuri.
>>
>>
>> I've been developing products using glusterfs for 2 years almost with my
>> co-workers.
>>
>> I got a problem that the products cannot recognize the time when heal is
>> triggered.
>>
>> I think healing affect the performance of glusterfs volume definitely.
>>
>> So, we should monitor whether healing is in progress or not.
>>
>>
>> To monitor it, event api is one of the best way, I guess.
>>
>> So I have created the issue including patch for it on bugzilla;
>> https://bugzilla.redhat.com/show_bug.cgi?id=1467543
>>
>>
>>
>> Can I get some feedbacks?
>>
>> Thanks in advance.
>>
>>
>> Best regards.
>>
>>
>> -----------------------------------------
>> 이 태 화
>> Taehwa Lee
>> Gluesys Co.,Ltd.
>> alghost.lee at gmail.com
>> 010-3420-6114, 070-8785-6591
>> -----------------------------------------
>>
>>
>
>
> --
> Pranith
>
>
>


-- 
Pranith
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20170706/e382a30d/attachment.html>