<div dir="ltr"><div><div><div><div>hi,<br></div> I have a couple of comments. Gerrit is good for comments :-), so post the patch I can ask you questions at the exact line.<br><br></div>need_heal_count won't be accurate because the indices in 'dirty' are being counted as is, there can be lot of false +ves in that. So I can review a bit more closely after I understand your requirements<br><br></div>It is better to have the ability to configure how frequently we need the event about heal progress. I see that you like 10 seconds, so we can keep that as default :-).<br><br></div>This is a very good use of EVENTING framework!<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 6, 2017 at 11:37 AM, Taehwa Lee <span dir="ltr"><<a href="mailto:alghost.lee@gmail.com" target="_blank">alghost.lee@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Thanks your response.</div><div><br></div><div><br></div><div>I want you to review the comments and patch updated again..</div><div><br></div><div>I think that events are needed not only when heal is started and finished but also while healing like rebalancing.</div><div><br></div><div><br></div><div>So I’ve developed and tested it. </div><div><br></div><div><br></div><div>Can you review the patch where is on bugzilla again?</div><div>: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1467543" target="_blank">https://bugzilla.redhat.com/<wbr>show_bug.cgi?id=1467543</a></div><div><br></div><div>Sorry to bother you :(</div><div><br></div><div><br></div><div>After your review, I’m going to try to send it on gerrit :D</div><div><br></div><div>Thanks in advance.</div><div><br></div><div>Best regards</div><span class=""><div><br></div><div><br></div><div><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><span class="m_1560572414874018471Apple-style-span" style="border-collapse:separate;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;line-height:normal;border-spacing:0px"><div style="word-wrap:break-word"><span class="m_1560572414874018471Apple-style-span" style="border-collapse:separate;color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><span class="m_1560572414874018471Apple-style-span" style="border-collapse:separate;color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><span class="m_1560572414874018471Apple-style-span" style="border-collapse:separate;color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><br></div><div style="word-wrap:break-word">------------------------------<wbr>-----------</div><div style="word-wrap:break-word">이 태 화<br>Taehwa Lee<br>Gluesys Co.,Ltd.<br><a href="mailto:alghost.lee@gmail.com" target="_blank">alghost.lee@gmail.com</a><br>010-3420-6114, 070-8785-6591</div><div style="word-wrap:break-word">------------------------------<wbr>-----------</div></span></div></span></div></span></div></span></div></div></div>
</div>
<br></span><div><blockquote type="cite"><div>2017. 7. 5. 오후 7:36, Pranith Kumar Karampuri <<a href="mailto:pkarampu@redhat.com" target="_blank">pkarampu@redhat.com</a>> 작성:</div><div><div class="h5"><br class="m_1560572414874018471Apple-interchange-newline"><div><div dir="ltr">patch looks good to me. Do you want to send it on gerrit?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 5, 2017 at 6:49 AM, Taehwa Lee <span dir="ltr"><<a href="mailto:alghost.lee@gmail.com" target="_blank">alghost.lee@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Hello, Karampuri.</div><div><br></div><div><br></div><div>I've been developing products using glusterfs for 2 years almost with my co-workers.</div><div><br></div><div>I got a problem that the products cannot recognize the time when heal is triggered.</div><div><br></div><div>I think healing affect the performance of glusterfs volume definitely.</div><div><br></div><div>So, we should monitor whether healing is in progress or not.</div><div><br></div><div><br></div><div>To monitor it, event api is one of the best way, I guess.</div><div><br></div><div>So I have created the issue including patch for it on bugzilla; <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1467543" target="_blank">https://bugzilla.redhat.com/sh<wbr>ow_bug.cgi?id=1467543</a></div><div><br></div><div><br></div><div><br></div><div>Can I get some feedbacks? </div><div><br></div><div>Thanks in advance.</div><div><br></div><div><br></div><div>Best regards.</div><div><br></div><div><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><span class="m_1560572414874018471m_291178856988597837Apple-style-span" style="border-collapse:separate;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;line-height:normal;border-spacing:0px"><div style="word-wrap:break-word"><span class="m_1560572414874018471m_291178856988597837Apple-style-span" style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><span class="m_1560572414874018471m_291178856988597837Apple-style-span" style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><span class="m_1560572414874018471m_291178856988597837Apple-style-span" style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><br></div><div style="word-wrap:break-word">------------------------------<wbr>-----------</div><div style="word-wrap:break-word">이 태 화<span class="m_1560572414874018471HOEnZb"><font color="#888888"><br>Taehwa Lee<br>Gluesys Co.,Ltd.<br><a href="mailto:alghost.lee@gmail.com" target="_blank">alghost.lee@gmail.com</a><br>010-3420-6114, 070-8785-6591</font></span></div><span class="m_1560572414874018471HOEnZb"><font color="#888888"><div style="word-wrap:break-word">------------------------------<wbr>-----------</div></font></span></span></div></span></div></span></div></span></div></div></div>
</div>
<br></div></blockquote></div><br><br clear="all"><br>-- <br><div class="m_1560572414874018471gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div>
</div></div></div></blockquote></div><br></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div>