[Gluster-devel] Spurious regression failure? tests/basic/ec/ec-background-heals.t

[Ashish Pandey]

Pranith, 

In this test tests/basic/ec/ec-background-heals.t, I think the line number 86 actually creating a heal entry instead of 
helping data heal quickly. What if all the data was already healed at that moment, truncate came and in preop set the dirty flag and at the 
end, as part of the heal, dirty flag was unset on previous good bricks only and the brick which acted as heal-sink still has dirty marked by truncate. 
That is why we are only seeing "1" as get_pending_heal_count. If a file was actually not healed it should be "2". 
If heal on this file completes and unset of dirty flag happens before truncate everything will be fine. 

I think we can wait for file to be heal without truncate? 

71 #Test that disabling background-heals still drains the queue 
72 TEST $CLI volume set $V0 disperse.background-heals 1 
73 TEST touch $M0/{a,b,c,d} 
74 TEST kill_brick $V0 $H0 $B0/${V0}2 
75 EXPECT_WITHIN $CONFIG_UPDATE_TIMEOUT "1" mount_get_option_value $M0 $V0-disperse-0 background-heals 
76 EXPECT_WITHIN $CONFIG_UPDATE_TIMEOUT "200" mount_get_option_value $M0 $V0-disperse-0 heal-wait-qlength 
77 TEST truncate -s 1GB $M0/a 
78 echo abc > $M0/b 
79 echo abc > $M0/c 
80 echo abc > $M0/d 
81 TEST $CLI volume start $V0 force 
82 EXPECT_WITHIN $CHILD_UP_TIMEOUT "3" ec_child_up_count $V0 0 
83 TEST chown root:root $M0/{a,b,c,d} 
84 TEST $CLI volume set $V0 disperse.background-heals 0 
85 EXPECT_NOT "0" mount_get_option_value $M0 $V0-disperse-0 heal-waiters 

86 TEST truncate -s 0 $M0/a # This completes the heal fast ;-) <<<<<<< 

87 EXPECT_WITHIN $HEAL_TIMEOUT "^0$" get_pending_heal_count $V0 

---- 
Ashish 





----- Original Message -----

From: "Raghavendra Gowdappa" <rgowdapp at redhat.com> 
To: "Nithya Balachandran" <nbalacha at redhat.com> 
Cc: "Gluster Devel" <gluster-devel at gluster.org>, "Pranith Kumar Karampuri" <pkarampu at redhat.com>, "Ashish Pandey" <aspandey at redhat.com> 
Sent: Wednesday, January 25, 2017 9:41:38 AM 
Subject: Re: [Gluster-devel] Spurious regression failure? tests/basic/ec/ec-background-heals.t 

Found another failure on same test: 
https://build.gluster.org/job/centos6-regression/2874/consoleFull 

----- Original Message ----- 
> From: "Nithya Balachandran" <nbalacha at redhat.com> 
> To: "Gluster Devel" <gluster-devel at gluster.org>, "Pranith Kumar Karampuri" <pkarampu at redhat.com>, "Ashish Pandey" 
> <aspandey at redhat.com> 
> Sent: Tuesday, January 24, 2017 9:16:31 AM 
> Subject: [Gluster-devel] Spurious regression failure? tests/basic/ec/ec-background-heals.t 
> 
> Hi, 
> 
> 
> Can you please take a look at 
> https://build.gluster.org/job/centos6-regression/2859/console ? 
> 
> tests/basic/ec/ec-background-heals.t has failed. 
> 
> Thanks, 
> Nithya 
> 
> _______________________________________________ 
> Gluster-devel mailing list 
> Gluster-devel at gluster.org 
> http://lists.gluster.org/mailman/listinfo/gluster-devel 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20170125/f8d43772/attachment.html>