<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 12pt; color: #000000"><div><br></div><div>Pranith,<br></div><div><br></div><div>In this test tests/basic/ec/ec-background-heals.t, I think the line number 86 actually creating a heal entry instead of <br></div><div>helping data heal quickly. What if all the data was already healed at that moment, truncate came and in preop set the dirty flag and at the<br></div><div>end, as part of the heal, dirty flag was unset on previous good bricks only and the brick which acted as heal-sink still has dirty marked by truncate.<br></div><div>That is why we are only seeing "1" as get_pending_heal_count. If a file was actually not healed it should be "2".<br></div><div>If heal on this file completes and unset of dirty flag happens before truncate everything will be fine.<br></div><div><br></div><div>I think we can wait for file to be heal without truncate?</div><div><br></div><div> 71 #Test that disabling background-heals still drains the queue<br> 72 TEST $CLI volume set $V0 disperse.background-heals 1<br> 73 TEST touch $M0/{a,b,c,d}<br> 74 TEST kill_brick $V0 $H0 $B0/${V0}2<br> 75 EXPECT_WITHIN $CONFIG_UPDATE_TIMEOUT "1" mount_get_option_value $M0 $V0-disperse-0 background-heals<br> 76 EXPECT_WITHIN $CONFIG_UPDATE_TIMEOUT "200" mount_get_option_value $M0 $V0-disperse-0 heal-wait-qlength<br> 77 TEST truncate -s 1GB $M0/a<br> 78 echo abc > $M0/b<br> 79 echo abc > $M0/c<br> 80 echo abc > $M0/d<br> 81 TEST $CLI volume start $V0 force<br> 82 EXPECT_WITHIN $CHILD_UP_TIMEOUT "3" ec_child_up_count $V0 0<br> 83 TEST chown root:root $M0/{a,b,c,d}<br> 84 TEST $CLI volume set $V0 disperse.background-heals 0<br> 85 EXPECT_NOT "0" mount_get_option_value $M0 $V0-disperse-0 heal-waiters</div><div><br> 86 TEST truncate -s 0 $M0/a # This completes the heal fast ;-) <<<<<<<<br></div><div><br></div><div> 87 EXPECT_WITHIN $HEAL_TIMEOUT "^0$" get_pending_heal_count $V0<br><br></div><div>----<br></div><div>Ashish<br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><hr id="zwchr"><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;"><b>From: </b>"Raghavendra Gowdappa" <rgowdapp@redhat.com><br><b>To: </b>"Nithya Balachandran" <nbalacha@redhat.com><br><b>Cc: </b>"Gluster Devel" <gluster-devel@gluster.org>, "Pranith Kumar Karampuri" <pkarampu@redhat.com>, "Ashish Pandey" <aspandey@redhat.com><br><b>Sent: </b>Wednesday, January 25, 2017 9:41:38 AM<br><b>Subject: </b>Re: [Gluster-devel] Spurious regression failure? tests/basic/ec/ec-background-heals.t<br><div><br></div>Found another failure on same test:<br>https://build.gluster.org/job/centos6-regression/2874/consoleFull<br><div><br></div>----- Original Message -----<br>> From: "Nithya Balachandran" <nbalacha@redhat.com><br>> To: "Gluster Devel" <gluster-devel@gluster.org>, "Pranith Kumar Karampuri" <pkarampu@redhat.com>, "Ashish Pandey"<br>> <aspandey@redhat.com><br>> Sent: Tuesday, January 24, 2017 9:16:31 AM<br>> Subject: [Gluster-devel] Spurious regression failure? tests/basic/ec/ec-background-heals.t<br>> <br>> Hi,<br>> <br>> <br>> Can you please take a look at<br>> https://build.gluster.org/job/centos6-regression/2859/console ?<br>> <br>> tests/basic/ec/ec-background-heals.t has failed.<br>> <br>> Thanks,<br>> Nithya<br>> <br>> _______________________________________________<br>> Gluster-devel mailing list<br>> Gluster-devel@gluster.org<br>> http://lists.gluster.org/mailman/listinfo/gluster-devel<br></div><div><br></div></div></body></html>