[Gluster-devel] mem-pool: New macro GF_CALLOC2/GF_MALLOC2 supports assign release function
mijinlong at open-fs.com
Wed Aug 30 10:50:34 UTC 2017
On 8/30/2017 18:38, Niels de Vos wrote:
> Hi Kinglong,
> You have two patches under review for which I would like to know your
> - mem-pool: New macro GF_CALLOC2/GF_MALLOC2 supports assign release function
> - mem-pool: always record mem_header for memory allocated by GF_XALLOC
> As discussed in the review comments, it would be better to move this
> functionality to api/src/... files. The allocations done by gfapi can
> then add their own (minimal) memory header, that have a pointer to a
> destructor/release function. Not having this in the 'struct mem_header'
> has its benefits.
> Do you plan to continue updating this change, or shall I send a new
> version of the patch(es) so that you can review them?
Yes, I will update this change as adding a separate memory header for gfapi.
I will push the new version this day or tomorrow.
Maybe we should abandon those two patches, and start a new review for the new patch?
More information about the Gluster-devel