[Gluster-devel] Release 3.12: Glusto run status

[Shwetha Panduranga]

we had the first  'rebalance status" for logging purposes.
wait_for_rebalance_to_complete will get the xml command output for
validations.  --xml ouputs go to debug log levels.

On Wed, Aug 30, 2017 at 4:35 PM, Nigel Babu <nigelb at redhat.com> wrote:

> Why are we failing because the first "rebalance status" fails? Isn't it
> supposed to check in a loop and wait until it succeeds?
>
> Specifically, I think line 288 and 289 need to be removed
> http://git.gluster.org/cgit/glusto-tests.git/tree/
> glustolibs-gluster/glustolibs/gluster/rebalance_ops.py#n288
>
> Is that a fair assessment?
>
> On Wed, Aug 30, 2017 at 4:28 PM, Shwetha Panduranga <spandura at redhat.com>
> wrote:
>
>> May be i should change the log message from 'Checking rebalance status'
>> to 'Logging rebalance status' because the first 'rebalance status' command
>> just does that . It executes 'rebalance status'. Now
>> wait_for_rebalance_to_complete validates rebalance is 'completed' within 5
>> minutes ( default time out ). If that makes sense i will make those changes
>> as well along with introducing the delay b/w 'start' and 'status'
>>
>> On Wed, Aug 30, 2017 at 4:26 PM, Atin Mukherjee <amukherj at redhat.com>
>> wrote:
>>
>>>
>>>
>>> On Wed, Aug 30, 2017 at 4:23 PM, Shwetha Panduranga <spandura at redhat.com
>>> > wrote:
>>>
>>>> This is the first check where we just execute 'rebalance status' .
>>>> That's the command which failed and hence failed the test case. If u see
>>>> the test case, the next step is wait_for_rebalance_to_complete (status
>>>> --xml). This is where we execute  rebalance status until 5 minutes for
>>>> rebalance to get completed. Even before waiting for rebalance, the first
>>>> execution of status command failed. Hence the test case failed.
>>>>
>>>
>>> Cool. So there is still a problem in the test case. We can't assume
>>> rebalance status to report back success immediately after rebalance start
>>> and I've explained the why part in the earlier thread. Why do we need to do
>>> an intermediate check of rebalance status before going for
>>> wait_for_rebalance_to_complete ?
>>>
>>>
>>>>
> --
> nigelb
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20170830/e4ea845d/attachment.html>