<div dir="ltr">we had the first 'rebalance status" for logging purposes. wait_for_rebalance_to_complete will get the xml command output for validations. --xml ouputs go to debug log levels.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 30, 2017 at 4:35 PM, Nigel Babu <span dir="ltr"><<a href="mailto:nigelb@redhat.com" target="_blank">nigelb@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Why are we failing because the first "rebalance status" fails? Isn't it supposed to check in a loop and wait until it succeeds?</div><div><br></div><div>Specifically, I think line 288 and 289 need to be removed <a href="http://git.gluster.org/cgit/glusto-tests.git/tree/glustolibs-gluster/glustolibs/gluster/rebalance_ops.py#n288" target="_blank">http://git.gluster.org/cgit/<wbr>glusto-tests.git/tree/<wbr>glustolibs-gluster/glustolibs/<wbr>gluster/rebalance_ops.py#n288</a><br></div><div><br></div><div>Is that a fair assessment?<br></div><div><div><div class="gmail_extra"><span class=""><br><div class="gmail_quote">On Wed, Aug 30, 2017 at 4:28 PM, Shwetha Panduranga <span dir="ltr"><<a href="mailto:spandura@redhat.com" target="_blank">spandura@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">May be i should change the log message from 'Checking rebalance status' to 'Logging rebalance status' because the first 'rebalance status' command just does that . It executes 'rebalance status'. Now wait_for_rebalance_to_complete validates rebalance is 'completed' within 5 minutes ( default time out ). If that makes sense i will make those changes as well along with introducing the delay b/w 'start' and 'status'<br></div><div class="m_5133835730274328652gmail-HOEnZb"><div class="m_5133835730274328652gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 30, 2017 at 4:26 PM, Atin Mukherjee <span dir="ltr"><<a href="mailto:amukherj@redhat.com" target="_blank">amukherj@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Aug 30, 2017 at 4:23 PM, Shwetha Panduranga <span dir="ltr"><<a href="mailto:spandura@redhat.com" target="_blank">spandura@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">This is the first check where we just execute 'rebalance status' . That's the command which failed and hence failed the test case. If u see the test case, the next step is wait_for_rebalance_to_complete (status --xml). This is where we execute rebalance status until 5 minutes for rebalance to get completed. Even before waiting for rebalance, the first execution of status command failed. Hence the test case failed. <br></div></blockquote><div><br></div></span><div>Cool. So there is still a problem in the test case. We can't assume rebalance status to report back success immediately after rebalance start and I've explained the why part in the earlier thread. Why do we need to do an intermediate check of rebalance status before going for wait_for_rebalance_to_complete ?</div><div><div class="m_5133835730274328652gmail-m_-5222011862098697951h5"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"></div><br clear="all"></blockquote></div></div></div></div></div></blockquote></div></div></div></div></blockquote><div> </div></div></span><span class="HOEnZb"><font color="#888888">-- <br><div class="m_5133835730274328652gmail_signature"><div dir="ltr">nigelb<br></div></div>
</font></span></div></div></div></div>
</blockquote></div><br></div>