[Gluster-devel] Preview request for cleaning up the global timer-wheel

[Niels de Vos]

Hi Poornima and others,

Could someone please review the patch that adds reference counting to
the timer-wheel structure that is used by glusterfs_ctx_t?

https://review.gluster.org/17068

> core: make the per glusterfs_ctx_t timer-wheel refcounted
> 
> xlators can use a 'global' timer-wheel for scheduling events. This
> timer-wheel is managed per glusterfs_ctx_t, but does not need to be
> allocated for every graph. When an xlator wants to use the timer-wheel,
> it will be instanciated on demand, and provided to xlators that request
> it later on.
> 
> By adding a reference counter to the glusterfs_ctx_t for the
> timer-wheel, the threads and structures can be cleaned up when the last
> xlator does not have a need for it anymore. In general, the xlators
> request the timer-wheel in init(), and they should return it in fini().
> 
> Because the timer-wheel is managed per glusterfs_ctx_t, the functions
> can be added to ctx.c and do not need to live in their very minimal
> tw.[ch] files.
> 
> Change-Id: I19d225b39aaa272d9005ba7adc3104c3764f1572
> BUG: 1442788
> Reported-by: Poornima G <pgurusid at redhat.com>
> Signed-off-by: Niels de Vos <ndevos at redhat.com>

Thanks,
Niels
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20170429/559a87f1/attachment.sig>