[Gluster-devel] Improve EXPECT/EXPECT_WITHIN result check in tests

[Xavier Hernandez]

On 02/05/16 14:09, Jeff Darcy wrote:
>> Would it be ok to change all regular expression checks to something like
>> this in include.rc ?
>>
>>      if [[ "$a" =~ ^$e$ ]]; then
>>
>> This will allow using regular expressions in EXPECT and EXPECT_WITHIN,
>> but will enforce full answer match in all cases, avoiding some possible
>> side effects.
>>
>> This needs some changes in many tests, but I think it's worth doing.
>>
>> What do you think ?
>
> I think it's worth it, and AFAICT it won't even require changing that
> many tests.
>

No there aren't too many. Basically '^' and '$' need to be removed from 
those tests that already use them, and special regexp characters must be 
escaped.

I'm already running modified regression tests to see if they pass.

Xavi