[Gluster-devel] Improve EXPECT/EXPECT_WITHIN result check in tests

Jeff Darcy jdarcy at redhat.com
Mon May 2 12:09:49 UTC 2016


> Would it be ok to change all regular expression checks to something like
> this in include.rc ?
> 
>      if [[ "$a" =~ ^$e$ ]]; then
> 
> This will allow using regular expressions in EXPECT and EXPECT_WITHIN,
> but will enforce full answer match in all cases, avoiding some possible
> side effects.
> 
> This needs some changes in many tests, but I think it's worth doing.
> 
> What do you think ?

I think it's worth it, and AFAICT it won't even require changing that
many tests.


More information about the Gluster-devel mailing list