[Gluster-devel] Regarding default_forget/releasedir/release() fops

[Soumya Koduri]

On 02/23/2016 05:02 PM, Jeff Darcy wrote:
>> Recently while doing some tests (which involved lots of inode_forget()),
>> I have noticed that my log file got flooded with below messages -
>>
>> [2016-02-22 08:57:44.025565] W [defaults.c:2889:default_forget] (-->
>> /usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x231)[0x7fd00f63c15d]
>> (-->
>> /usr/local/lib/libglusterfs.so.0(default_forget+0x44)[0x7fd00f6cda2b]
>> (--> /usr/local/lib/libglusterfs.so.0(+0x39706)[0x7fd00f64b706] (-->
>> /usr/local/lib/libglusterfs.so.0(+0x397d2)[0x7fd00f64b7d2] (-->
>> /usr/local/lib/libglusterfs.so.0(+0x3be08)[0x7fd00f64de08] )))))
>> 0-gfapi: xlator does not implement forget_cbk
>>
>>   From the code, looks like we throw a warning in default-tmpl.c if any
>> xlator hasn't implemented forget(), releasedir() and release().
>>
>> Though I agree it warns us about possible leaks which may happen if
>> these fops are not supported, it is annoying to have these messages
>> flooded in the log file which grew >1GB within few minutes.
>>
>> Could you please confirm if it was intentional to throw this warning so
>> that all xlators shall have these fops implemented or if we can change
>> the log level to DEBUG?
>
> It is intentional, and I would prefer that it be resolved by having
> translators implement these calls, but it doesn't need to be a warning.
> DEBUG would be fine.

Thanks for the confirmation. I have posted below patches -

http://review.gluster.org/#/q/status:open+project:glusterfs+branch:master+topic:bug-1311124

Thanks,
Soumya

>