[Gluster-devel] Bitrot stub forget()

Venky Shankar vshankar at redhat.com
Tue Feb 16 15:53:31 UTC 2016


Hey Raghu,

Bitrot stub inode forget implementation (br_stub_forget()) deletes the bad object
marker (under quarantine directory) if present. This looks incorrect as ->forget()
can be trigerred when inode table LRU size exceeeds configured limit - check bug
#1308961 which tracks this issue. I recall that protocol/server calls inode_forget()
on negative lookup (that might not invoke ->forget() though) and that's the reason
why br_stub_forget() has this code.

So, would it make sense to purge bad object marker just in lookup()? There might be
a need to do the same in unlink() in case the object was removed by the client.

Thoughts?

Thanks,

                Venky


More information about the Gluster-devel mailing list