[Gluster-devel] Fwd: "gluster peer probe" on localhost should fail with appropriate value

[Manikandan Selvaganesh]

--
Regards,
Manikandan Selvaganesh.

----- Forwarded Message -----
From: Manikandan Selvaganesh <mselvaga at redhat.com>
To: gluster-devel at gluster.org
Sent: Fri, 17 Jul 2015 05:58:25 -0400 (EDT)
Subject: "gluster peer probe" on localhost should fail with appropriate value

Hi,

Currently, the command "gluster peer probe $localhost" shows "peer probe: success. Probe on localhost not needed" with a ret value of 0.

As per the discussion with Satheesaran(QE), since, we are showing a warning message, "Probe on localhost not needed", so, would it be better if we show "peer probe: failure: Probe on localhost not needed" with a ret value of -1.

In my opinion, it would be better to change if no script is dependent on this ret value. Are there any automation scripts or other functions which uses this ret value or is there any reason to not return an error(ret = -1)?

I have sent a patch[1] changing the ret value to -1 if its a local host and "gluster peer probe $localhost" would show "peer probe: failed: Probe on localhost not needed".

[1] http://review.gluster.org/#/c/11704/

Any suggestions would be helpful!!


--
Thanks & regards,
Manikandan Selvaganesh.