[Gluster-devel] Regarding the coding guidelines script
kdhananj at redhat.com
Mon Sep 22 11:33:54 UTC 2014
Ah! Warnings are not the same as "errors". :)
----- Original Message -----
> From: "Krutika Dhananjay" <kdhananj at redhat.com>
> To: "FNU Harshavardhana" <fharshav at redhat.com>
> Cc: "Gluster Devel" <gluster-devel at gluster.org>
> Sent: Monday, September 22, 2014 4:56:43 PM
> Subject: [Gluster-devel] Regarding the coding guidelines script
> I just ran ./rfc.sh to push my patch our for review and it failed the
> checkpatch.pl test.
> One of the warnings says the following:
> WARNING: quoted string split across lines
> #93: FILE: xlators/cluster/afr/src/afr-self-heal-entry.c:237:
> + gf_log (this->name, GF_LOG_DEBUG, "Gfid mismatch "
> + "detected for <%s/%s>, %s on %s and %s on %s. "
> I am not sure how we can get around this.
> Most of our gf_log() message strings (especially the ones inside nested
> blocks) will easily exceed 80 columns if this rule is going to be enforced.
> Do we really need this check?
> Gluster-devel mailing list
> Gluster-devel at gluster.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Gluster-devel