[Gluster-devel] Something wrong with release-3.6 branch

[Harshavardhana]

>   /home/jenkins/root/workspace/rackspace-regression-2GB/xlators/cluster/dht/src/dht-common.c: In function ‘dht_lookup_everywhere_done’:
>   /home/jenkins/root/workspace/rackspace-regression-2GB/xlators/cluster/dht/src/dht-common.c:1229: warning: implicit declaration of function ‘dht_fill_dict_to_avoid_unlink_of_migrating_file’
>
> Guessing these are significant. :)


00:08:09: harsha at sysrq:~/repos/glusterfs(master)$ git grep
dht_fill_dict_to_avoid_unlink_of_migrating_file
xlators/cluster/dht/src/dht-common.c:dht_fill_dict_to_avoid_unlink_of_migrating_file
(dict_t *dict) {
xlators/cluster/dht/src/dht-common.c:                        ret =
dht_fill_dict_to_avoid_unlink_of_migrating_file
xlators/cluster/dht/src/dht-common.c:                          ret =
dht_fill_dict_to_avoid_unlink_of_migrating_file
xlators/cluster/dht/src/dht-common.c:                        ret =
dht_fill_dict_to_avoid_unlink_of_migrating_file
xlators/cluster/dht/src/dht-common.h:dht_fill_dict_to_avoid_unlink_of_migrating_file
(dict_t *dict);
00:08:10: harsha at sysrq:~/repos/glusterfs(master)$


00:08:23: harsha at sysrq:~/repos/glusterfs(release-3.6)$ git grep
dht_fill_dict_to_avoid_unlink_of_migrating_file
xlators/cluster/dht/src/dht-common.c:                          ret =
dht_fill_dict_to_avoid_unlink_of_migrating_file
00:08:24: harsha at sysrq:~/repos/glusterfs(release-3.6)$

Interestingly not implemented or defined, part of this patch.

~~~~
commit 13a044ab4d643a39d8138ab33226162ef125dbd3
Author: Venkatesh Somyajulu <vsomyaju at redhat.com>
Date:   Thu Sep 4 14:08:18 2014 -0400

    cluster/dht: Added keys in dht_lookup_everywhere_done

    Case where both cached  (C1)  and hashed file are found,
    but hash does not point to above cached node (C1), then
    dont unlink if either fd-is-open on hashed or
    linkto-xattr is not found.

    Change-Id: I7ef49b88d2c88bf9d25d3aa7893714e6c0766c67
    BUG: 1138385
    Signed-off-by: Venkatesh Somyajulu <vsomyaju at redhat.com>

    Change-Id: I86d0a21d4c0501c45d837101ced4f96d6fedc5b9
    Signed-off-by: Venkatesh Somyajulu <vsomyaju at redhat.com>
    Reviewed-on-master: http://review.gluster.org/8429
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: susant palai <spalai at redhat.com>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>
    Reviewed-on: http://review.gluster.org/8607
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>
~~~

I would blame dumb GCC, clang would have never progressed this even
for a build.

-- 
Religious confuse piety with mere ritual, the virtuous confuse
regulation with outcomes