[Gluster-devel] Query regarding GF_ASSERT macro

[Vijay Bellur]

On 01/08/2014 11:47 AM, Pranith Kumar Karampuri wrote:
>
>
> ----- Original Message -----
>> From: "Harshavardhana" <harsha at harshavardhana.net>
>> To: "Vijay Bellur" <vbellur at redhat.com>
>> Cc: "Xavier Hernandez" <xhernandez at datalab.es>, gluster-devel at nongnu.org, "Atin Mukherjee" <amukherj at redhat.com>
>> Sent: Wednesday, January 8, 2014 11:41:33 AM
>> Subject: Re: [Gluster-devel] Query regarding GF_ASSERT macro
>>
>>>
>>> I think we need to do the following:
>>>
>>> 1. Change GF_ASSERT to be a simple wrapper over assert() and get rid of the
>>> -DDEBUG dependency.
>>>
>>> 2. Add -DNDEBUG for GA releases. qa releases to be built with assert()
>>> enabled.
>
> This may pose problems as customers/users see different failures compared to what QE found.
>

Ideally, all assertion failures need to be caught in our own testing 
before GA. The chances of assertion failures cropping up post GA should 
be very low. If we see more failures in GA releases due to assert() 
being a NOOP, it normally indicates that more testing is needed pre GA :).

-Vijay