[Gluster-devel] Query regarding GF_ASSERT macro

[Pranith Kumar Karampuri]

----- Original Message -----
> From: "Harshavardhana" <harsha at harshavardhana.net>
> To: "Vijay Bellur" <vbellur at redhat.com>
> Cc: "Xavier Hernandez" <xhernandez at datalab.es>, gluster-devel at nongnu.org, "Atin Mukherjee" <amukherj at redhat.com>
> Sent: Wednesday, January 8, 2014 11:41:33 AM
> Subject: Re: [Gluster-devel] Query regarding GF_ASSERT macro
> 
> >
> > I think we need to do the following:
> >
> > 1. Change GF_ASSERT to be a simple wrapper over assert() and get rid of the
> > -DDEBUG dependency.
> >
> > 2. Add -DNDEBUG for GA releases. qa releases to be built with assert()
> > enabled.

This may pose problems as customers/users see different failures compared to what QE found.

> >
> > 3. Change GF_ASSERT to GF_VALIDATE_xxx wherever it is being used
> > defensively
> > and not as an assertion.
> >
> > Might be a good idea to log a bug and track this activity if everybody is
> > fine with the guidelines.
> 
> +1 from me
> 
> --
> Religious confuse piety with mere ritual, the virtuous confuse
> regulation with outcomes
> 
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at nongnu.org
> https://lists.nongnu.org/mailman/listinfo/gluster-devel
>