[Gluster-devel] Fwd: New Defects reported by Coverity Scan for GlusterFS

[Brian Foster]

On 01/02/2014 06:32 AM, Vijay Bellur wrote:
> 
> 
> 
> On 12/31/2013 04:53 PM, Lalatendu Mohanty wrote:
>> Here is the last Coverity scan report in 2013 for master branch of
>> GlusterFS. I have tried to cover the whole code base for this Coverity
>> scan by enabling possible translators. Happy new year Gluster Ants :)
> 
> Thanks, Lala and Happy new year to you too! :)
> 
>> Please find the latest report on new defect(s) introduced to GlusterFS
>> found with Coverity Scan.
>>
>> Defect(s) Reported-by: Coverity Scan
>> Showing 7 of 291 defect(s)
> 
> Avati, Brian: All these errors seem to be coming from the imported qemu
> code. Do we mark them as false positives as we probably do not intend
> fixing them?
> 

That's what I would vote for, or to just skip scanning the imported qemu
code if that is an option..? We probably don't want to make any
proactive changes to this code beyond the minimal hacks required to make
the code work with the qemu-block translator and/or fixes for any
significant bugs that we happen to stumble on. In the latter case, those
should probably be reported to and fixed in the qemu project first and
"rebased" back into our repo.

Brian

> Cheers,
> Vijay
> 
>>
>>
>> ** CID 26092:  Argument cannot be negative  (NEGATIVE_RETURNS)
>> /contrib/uuid/gen_uuid.c: 331 in get_clock()
>>
>> ** CID 1005337:  Uninitialized scalar variable  (UNINIT)
>> /contrib/qemu/util/oslib-posix.c: 224 in qemu_utimens()
>> /contrib/qemu/util/oslib-posix.c: 225 in qemu_utimens()
>>
>> ** CID 982366:  Logically dead code  (DEADCODE)
>> /contrib/qemu/util/aes.c: 826 in AES_set_encrypt_key()
>>
>> ** CID 1005329:  Unused pointer value  (UNUSED_VALUE)
>> /contrib/qemu/block/qed.c: 687 in bdrv_qed_co_is_allocated()
>>
>> ** CID 1005328:  Unused pointer value  (UNUSED_VALUE)
>> /contrib/qemu/block/qed.c: 1403 in bdrv_qed_co_write_zeroes()
>>
>> ** CID 1005324:  Unused pointer value  (UNUSED_VALUE)
>> /contrib/qemu/qobject/json-parser.c: 545 in parse_array()
>>
>> ** CID 1005323:  Unused pointer value  (UNUSED_VALUE)
>> /contrib/qemu/qobject/json-parser.c: 466 in parse_object()
>>
>>
>>
>>
>