[Gluster-devel] Clean up build system

[Jeff Darcy]

On 09/24/2012 03:16 AM, Jan Engelhardt wrote:
> On Monday 2012-09-24 08:55, Anand Avati wrote:
> 
>> Really appreciate this cleanup. Can you please submit the patches at 
>> http://review.gluster.org as described in 
>> http://www.gluster.org/community/documentation/index.php/Development_Work_Flow? 
>> Thanks! Avati
> 
> There are two bugs in your development model:
>  - it requires registration
>  - requires entering patches in some awkward web form
>    defeating the whole purpose of git send-email
> 
> That makes it _very_ cumbersome for passers-by.

Perhaps, but the goal is to keep the *entire* process - not just patch
submission but also patch review - more open.  Reviewing patches in gerrit is
much more convenient for most people, and does a better job of facilitating
review conversations than dumping them into the -devel list intermingled with
every other conversation there.  That's why projects much bigger than ours use
gerrit, and use it to good effect.

That said, if you're unwilling to accept a development process that differs one
iota from what you've used elsewhere, there is a precedent for team members
"shepherding" patches from others.  They would show up e.g. with the following
headers (from fe4777660a0a92da6da582103690fa0c2e5c7496).

    Original-author: domwo <glusterfs at wollina.de>
    Signed-off-by: domwo <glusterfs at wollina.de>
    Signed-off-by: Jeff Darcy <jdarcy at redhat.com>

Note that we absolutely do require the Signed-off-by line to indicate that you
are authorized to yield any copyright on your submissions and thus prevent
those submissions from threatening the livelihood of every other developer
because of IP lawsuits (same reason that the same thing is required on Linux
kernel submissions BTW).  If you prefer to go that route, let us know.