[Bugs] [Bug 1729221] New: Upcall: Avoid sending upcalls for invalid Inode

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1729221

            Bug ID: 1729221
           Summary: Upcall: Avoid sending upcalls for invalid Inode
           Product: GlusterFS
           Version: 4.1
          Hardware: All
                OS: All
            Status: NEW
         Component: upcall
          Keywords: Triaged
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: skoduri at redhat.com
                CC: atumball at redhat.com, bugs at gluster.org, pasik at iki.fi
        Depends On: 1718338, 1720633, 1720634
            Blocks: 1717784, 1726935
  Target Milestone: ---
    Classification: Community



+++ This bug was initially created as a clone of Bug #1720633 +++

+++ This bug was initially created as a clone of Bug #1718338 +++

Description of problem:

For nameless LOOKUPs, server creates a new inode which shall remain invalid
until the fop is successfully processed post which it is linked to the inode
table. 

But incase if there is an already linked inode for that entry, it discards that
newly created inode which results in upcall notification. This may result in
client being bombarded with unnecessary upcalls affecting performance if the
data set is huge.

This issue can be avoided by looking up and storing the upcall context in the
original linked inode (if exists), thus saving up on those extra callbacks.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2019-06-07 14:10:52 UTC ---

REVIEW: https://review.gluster.org/22840 (upcall: Avoid sending notifications
for invalid inodes) posted (#1) for review on master by soumya k

--- Additional comment from Worker Ant on 2019-06-14 12:48:34 UTC ---

REVIEW: https://review.gluster.org/22873 (upcall: Avoid sending notifications
for invalid inodes) posted (#1) for review on release-6 by soumya k

--- Additional comment from Pasi Karkkainen on 2019-06-24 09:55:02 UTC ---

Hmm.. it seems merge to 6.x branch is "blocked" due to a build failure
regression?

https://review.gluster.org/#/c/glusterfs/+/22873/

--- Additional comment from Amar Tumballi on 2019-07-05 08:06:20 UTC ---

It got fixed now. Good to get merged soon.

--- Additional comment from Worker Ant on 2019-07-05 09:19:24 UTC ---

REVIEW: https://review.gluster.org/22873 (upcall: Avoid sending notifications
for invalid inodes) merged (#6) on release-6 by hari gowtham


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1717784
[Bug 1717784] Ganesha-gfapi logs are flooded with error messages related to
"gf_uuid_is_null(gfid)) [Invalid argument]" when lookups are running from
multiple clients
https://bugzilla.redhat.com/show_bug.cgi?id=1718338
[Bug 1718338] Upcall: Avoid sending upcalls for invalid Inode
https://bugzilla.redhat.com/show_bug.cgi?id=1720633
[Bug 1720633] Upcall: Avoid sending upcalls for invalid Inode
https://bugzilla.redhat.com/show_bug.cgi?id=1720634
[Bug 1720634] Upcall: Avoid sending upcalls for invalid Inode
https://bugzilla.redhat.com/show_bug.cgi?id=1726935
[Bug 1726935] (glusterfs-6.4) - GlusterFS 6.4 tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.