[Bugs] [Bug 1746118] New: capture stat failure error while setting the gfid

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1746118

            Bug ID: 1746118
           Summary: capture stat failure error while setting the gfid
           Product: GlusterFS
           Version: mainline
            Status: NEW
         Component: posix
          Assignee: bugs at gluster.org
          Reporter: rabhat at redhat.com
                CC: bugs at gluster.org
        Depends On: 1736481, 1736482
  Target Milestone: ---
    Classification: Community



+++ This bug was initially created as a clone of Bug #1736482 +++

+++ This bug was initially created as a clone of Bug #1736481 +++

Description of problem:

For create operation, after the entry is created, posix xlator tries to set the
gfid for that entry. While doing that, there are several places where setting
gfid can fail. While the failure is handled in all the cases, for one of the
failure cases, the errno is not captured. Capturing this might help in
debugging.

int
posix_gfid_set(xlator_t *this, const char *path, loc_t *loc, dict_t *xattr_req,
               pid_t pid, int *op_errno)
{
    uuid_t uuid_req;
    uuid_t uuid_curr;
    int ret = 0;
    ssize_t size = 0;
    struct stat stat = {
        0,
    };

    *op_errno = 0;

    if (!xattr_req) {
        if (pid != GF_SERVER_PID_TRASH) {
            gf_msg(this->name, GF_LOG_ERROR, EINVAL, P_MSG_INVALID_ARGUMENT,
                   "xattr_req is null");
            *op_errno = EINVAL;
            ret = -1;
        }
        goto out;
    }

   if (sys_lstat(path, &stat) != 0) {
        ret = -1;
        gf_msg(this->name, GF_LOG_ERROR, errno, P_MSG_LSTAT_FAILED,
               "lstat on %s failed", path);
        goto out;
    }

HERE, errno is not captured.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2019-08-01 19:47:09 UTC ---

REVIEW: https://review.gluster.org/23144 (storage/posix: set the op_errno to
proper errno during gfid set) posted (#1) for review on master by Raghavendra
Bhat

--- Additional comment from Worker Ant on 2019-08-04 07:09:48 UTC ---

REVIEW: https://review.gluster.org/23144 (storage/posix: set the op_errno to
proper errno during gfid set) merged (#2) on master by Amar Tumballi


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1736481
[Bug 1736481] capture stat failure error while setting the gfid
https://bugzilla.redhat.com/show_bug.cgi?id=1736482
[Bug 1736482] capture stat failure error while setting the gfid
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.