[Bugs] [Bug 1630673] New: geo-rep: geo-rep config set fails to set rsync-options

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1630673

            Bug ID: 1630673
           Summary: geo-rep: geo-rep config set fails to set rsync-options
           Product: GlusterFS
           Version: 5
         Component: geo-replication
          Severity: medium
          Priority: high
          Assignee: bugs at gluster.org
          Reporter: khiremat at redhat.com
                CC: bugs at gluster.org
        Depends On: 1629561
            Blocks: 1630140



+++ This bug was initially created as a clone of Bug #1629561 +++

Description of problem:
geo-rep config fails to set rsync-options to "--ignore-missing-args"


Version-Release number of selected component (if applicable):
mainline

How reproducible:
Always

Steps to Reproduce:
1. Setup geo-rep between two gluster volumes and start
2. gluster vol set <master> <slavehost>::<slavevol> config rsync-options
"--ignore-missing-args"

Actual results:
config set fails

Expected results:
config set should not fail

Additional info:

--- Additional comment from Worker Ant on 2018-09-17 03:35:58 EDT ---

REVIEW: https://review.gluster.org/21191 (geo-rep: Fix issues related config
set) posted (#1) for review on master by Kotresh HR

--- Additional comment from Worker Ant on 2018-09-18 00:28:41 EDT ---

COMMIT: https://review.gluster.org/21191 committed in master by "Amar Tumballi"
<amarts at redhat.com> with a commit message- geo-rep: Fix issues related config
set

1. '--ignore-mising-args' option for rsync is not
   being used even though the rsync version is
   greater than 3.1.0. Fixed the same.

2. '--existing' option for rsync is also not being
   used. Fixed the same.

3. geo-rep config fails to set rsync-options as the
   value contains '--'. Interestingly, python argsparse
   treats the value with '--' (e.g., --ignore-missing-args)
   as option. But when passed with something like
   --value=--ignore-missing-args, it succeeds. Fixed the
   same.

Change-Id: Iaeb838acaff1c2920fee9c7f920c99edce13a0a1
Signed-off-by: Kotresh HR <khiremat at redhat.com>
fixes: bz#1629561


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1629561
[Bug 1629561] geo-rep: geo-rep config set fails to set rsync-options
https://bugzilla.redhat.com/show_bug.cgi?id=1630140
[Bug 1630140] geo-rep: geo-rep config set fails to set rsync-options
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.