[Bugs] [Bug 1626350] New: [Disperse] Don' t send final version update if non data fop succeeded

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1626350

            Bug ID: 1626350
           Summary: [Disperse] Don't send final version update if non data
                    fop succeeded
           Product: Red Hat Gluster Storage
           Version: 3.4
         Component: disperse
          Assignee: aspandey at redhat.com
          Reporter: aspandey at redhat.com
        QA Contact: nchilaka at redhat.com
                CC: bugs at gluster.org, jahernan at redhat.com,
                    pkarampu at redhat.com, rhs-bugs at redhat.com,
                    sankarshan at redhat.com, storage-qa-internal at redhat.com
        Depends On: 1623759



+++ This bug was initially created as a clone of Bug #1623759 +++

Description of problem:


When optimistic changelog is enabled, we do not set dirty xattr for non data
fops in preop. While releasing lock, if everything went well and all the bricks
are up, we just send version update on all he bricks of that subvol.

This final xattrop to update a version is actually not required in this case as
it will just increase the version and will serve no purpose as dirty was not
set at all.

We will have two advantage if we do not update finale version in this case-

1 - We can avoid sending final xattrop which in turn improves performance.

2 - Let's say the final xattrop, during unlock, failed on 3 bricks (config 4+2)
and succeeded on 3 brick because of brick failure or connection fluctuation,
then the file will be inaccessible even if stats of that file are fine.

If we do not do final xattrop in this case we can avoid one case where this
case might hit.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2018-09-06 02:18:46 EDT ---

REVIEW: https://review.gluster.org/21105 (cluster/ec: Don't update
trusted.ec.version if fop succeeds) posted (#1) for review on master by Ashish
Pandey


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1623759
[Bug 1623759] [Disperse] Don't send final version update if non data fop
succeeded
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZKaCbvzEXS&a=cc_unsubscribe