[Bugs] [Bug 1562670] Run libgfapi-python tests on Gerrit against glusterfs changes

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1562670

Prashanth Pai <ppai at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(ppai at redhat.com)  |



--- Comment #6 from Prashanth Pai <ppai at redhat.com> ---
(In reply to Niels de Vos from comment #5)
> I think we might need to add a way to do feature detection through new gfapi
> function.
> 
> How about adding this:
> 
> int glfs_supports(glfs_t *fs, enum glfs_feature)
> 
> enum glfs_features {
>     GFAPI_READLINK_HAS_FOLLOW = 1,
>     GFAPI_GETXATTR_RETURNS_STAT = 2,
>     ...
> }
> 
> It can return 1=YES, 0=NO, -1=unknown feature. Any changes in the API can
> then be dynamically checked, making it possible for non-compiled languages
> (like Python) to handle different versions. Some features may be available
> only when a particular option is set in for the volume, by passing the
> glfs_t it would be possible to support these kind of requests as well.

Sounds okay to me

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.