[Bugs] [Bug 1651502] New: [Disperse] : Set others.eager-lock on for ec-1468261.t test to pass

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 20 08:55:28 UTC 2018


https://bugzilla.redhat.com/show_bug.cgi?id=1651502

            Bug ID: 1651502
           Summary: [Disperse] : Set others.eager-lock on for ec-1468261.t
                    test to pass
           Product: GlusterFS
           Version: 5
         Component: disperse
          Assignee: bugs at gluster.org
          Reporter: aspandey at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org,
                    jahernan at redhat.com, pkarampu at redhat.com
        Depends On: 1632161



+++ This bug was initially created as a clone of Bug #1632161 +++

Description of problem:


tests/basic/ec/ec-1468261.t
In the above test we are relying on eager-lock time duration of 1 second to
delay the post op + unlock phase of entry fop so that in this 1 second we can
kill 2 bricks and dirty on directory could be set.

However, we have set the others.eager-lock as OFF by default in out code. So
this test is not getting 1 second delay in postop+unlock phase and so dirty
flag is not getting set. In fact killing of brick is not impact at all on this
fop.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Run the above test using prove
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Ashish Pandey on 2018-09-24 05:20:14 EDT ---

To fix this issue, we should set the others.eager-lock option to "ON" in the
beginning of this test.

--- Additional comment from Worker Ant on 2018-09-24 05:26:05 EDT ---

REVIEW: https://review.gluster.org/21254 (cluster/ec: Fix failure of
tests/basic/ec/ec-1468261.t) posted (#1) for review on master by Ashish Pandey

--- Additional comment from Worker Ant on 2018-09-25 09:58:25 EDT ---

COMMIT: https://review.gluster.org/21254 committed in master by "Xavi
Hernandez" <xhernandez at redhat.com> with a commit message- cluster/ec: Fix
failure of tests/basic/ec/ec-1468261.t

Problem:
In this test we are relying on eager-lock time
duration of 1 second to delay the post op + unlock phase
of an entry fop so that in this 1 second we can kill 2
bricks and dirty on directory could be set.

Solution:
To fix this issue, we should set the others.eager-lock
option to "ON" explicitly in the beginning of this test.

Change-Id: I19bbb9c15d7bdf96a96b20587c618192d0b740ef
fixes bz#1632161
Signed-off-by: Ashish Pandey <aspandey at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1632161
[Bug 1632161] [Disperse] : Set others.eager-lock on for ec-1468261.t test
to pass
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list