[Bugs] [Bug 1575707] New: Gluster volume smb share options are getting overwritten after restating the gluster volume

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1575707

            Bug ID: 1575707
           Summary: Gluster volume smb share options are getting
                    overwritten after restating the gluster volume
           Product: GlusterFS
           Version: 4.1
         Component: scripts
          Keywords: Triaged
          Severity: high
          Priority: high
          Assignee: bugs at gluster.org
          Reporter: anoopcs at redhat.com
                CC: annair at redhat.com, anoopcs at redhat.com,
                    asriram at redhat.com, bugs at gluster.org,
                    divya at redhat.com, gdeschner at redhat.com,
                    ira at redhat.com, nlevinki at redhat.com,
                    pgurusid at redhat.com, plambri at redhat.com,
                    rgowdapp at redhat.com, rtalur at redhat.com,
                    sankarshan at redhat.com, vdas at redhat.com,
                    vumrao at redhat.com
        Depends On: 1558921
            Blocks: 1164778



+++ This bug was initially created as a clone of Bug #1558921 +++

+++ This bug was initially created as a clone of Bug #1164778 +++

Description of problem:
Gluster volume smb share options are getting overwritten whenever we restart
the volume.

Version-Release number of selected component (if applicable):
mainline

How reproducible:
Always

Steps to Reproduce:
1. Modify any of the field from gluster volume share in /etc/samba/smb.conf
2. Like "read only" = "no" to "yes"
3. Stop and start the volume 
4. It will again become "read only" = "no" 

Actual results:
Changed configuration parameters are coming back to default value

Expected results:
They should not 

Additional info:
This is happening because we delete all gluster volume share at the time of
stopping the volume with help of gluster smb hook scripts and again we freshly
create these gluster volume shares when we start the volume.

--- Additional comment from Anoop C S on 2018-03-21 19:46:41 IST ---

https://review.gluster.org/#/c/19750/

--- Additional comment from Worker Ant on 2018-05-05 00:38:29 IST ---

REVIEW: https://review.gluster.org/19750 (extras/hooks: Do not blindly remove
volume share from smb.conf) posted (#2) for review on master by Anoop C S

--- Additional comment from Worker Ant on 2018-05-07 10:34:31 IST ---

COMMIT: https://review.gluster.org/19750 committed in master by "Poornima G"
<pgurusid at redhat.com> with a commit message- extras/hooks: Do not blindly
remove volume share from smb.conf

When Gluster volumes are shared via Samba, any extra smb.conf parameter
setting done by administrator to those shares are lost during restart
of the volume. Instead of removing the whole share completely from
smb.conf(via hook scripts during volume stop) it is better to make it
temporarily unavailable to end-users till the volume is started again.
Therefore we make use of a smb.conf parameter named 'available'[1] to
achieve the above intend.

[1] https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html

Change-Id: I68a9055b50791f6ffd3b95a3c13d858a75fa6530
fixes: bz#1558921
BUG: 1558921
Signed-off-by: Anoop C S <anoopcs at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1558921
[Bug 1558921] Gluster volume smb share options are getting overwritten
after restating the gluster volume
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.