[Bugs] [Bug 1587908] New: Fix deadlock in failure codepath of shard fsync

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1587908

            Bug ID: 1587908
           Summary: Fix deadlock in failure codepath of shard fsync
           Product: GlusterFS
           Version: 4.1
         Component: sharding
          Keywords: Triaged
          Severity: high
          Priority: high
          Assignee: kdhananj at redhat.com
          Reporter: kdhananj at redhat.com
        QA Contact: bugs at gluster.org
                CC: bugs at gluster.org



Description of problem:

        LOCK (&frame->lock);
        {
                if (op_ret < 0) {
                        local->op_ret = op_ret;
                        local->op_errno = op_errno;
                        goto out;
                }
                shard_inode_ctx_set (local->fd->inode, this, postbuf, 0,
                                     SHARD_MASK_TIMES);
        }
        UNLOCK (&frame->lock);

When op_ret is < 0, the control goes to out without unlocking frame->lock.
This can lead to a deadlock.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.