[Bugs] [Bug 1608991] New: Remove code duplication in socket
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jul 26 16:23:39 UTC 2018
https://bugzilla.redhat.com/show_bug.cgi?id=1608991
Bug ID: 1608991
Summary: Remove code duplication in socket
Product: GlusterFS
Version: mainline
Component: transport
Keywords: Triaged
Assignee: bugs at gluster.org
Reporter: kdhananj at redhat.com
CC: bugs at gluster.org
Description of problem:
While I was reading code, I saw that socket_submit_request() and
socket_submit_reply() are identical except for @a_byte and
the source of @msg object being different.
Check
https://github.com/gluster/glusterfs/blob/2836e158f38eb9ed070de88b64a3a8758cd2d4c0/rpc/rpc-transport/socket/src/socket.c#L3741
and
https://github.com/gluster/glusterfs/blob/2836e158f38eb9ed070de88b64a3a8758cd2d4c0/rpc/rpc-transport/socket/src/socket.c#L3815
and spot the difference yourself!
Version-Release number of selected component (if applicable):
How reproducible:
Steps to Reproduce:
1.
2.
3.
Actual results:
Expected results:
Additional info:
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
More information about the Bugs
mailing list