[Bugs] [Bug 1538723] New: build (release-4.0): glibc has removed legacy rpc headers and rpcgen in Fedora28, use libtirpc

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1538723

            Bug ID: 1538723
           Summary: build (release-4.0): glibc has removed legacy rpc
                    headers and rpcgen in Fedora28, use libtirpc
           Product: GlusterFS
           Version: mainline
         Component: build
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: kkeithle at redhat.com
                CC: anoopcs at redhat.com, bugs at gluster.org,
                    ndevos at redhat.com
        Depends On: 1536186
            Blocks: 1536187



+++ This bug was initially created as a clone of Bug #1536186 +++

Description of problem:

See $Summary. Other Linux distributions are doing the same; some others already
have.

Switch to libtirpc(-devel) and unbundled rpcgen packages. For now rpcgen is
still provided by the glibc-rpcgen RPM, but rpcsvc-proto's rpcgen subpackage is
available now but will not be used until glibc-rpcgen is retired. (note,
rpcsvc-proto's rpcgen is just named rpcgen-...rpm. I.e. not
rpcsvc-proto-rpcgen.) Right now either one will satisfy the BuildRequires:
rpcgen.

Also, when a .spec file has
  BuildRequires: foo-devel
it is not necessary to also have:
  BuildRequires: foo
or even:
  BuildRequires: foo foo-devel

The foo-devel package has a dependency on foo, which will install foo
automatically. It's usually also not necessary to have a corresponding
  Requires: foo

as the rpmbuild process will also automatically determine the install-time
dependencies.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2018-01-18 15:28:04 EST ---

REVIEW: https://review.gluster.org/19235 (build: glibc has removed rpc headers
and rpcgen in Fedora28, use libtirpc) posted (#1) for review on master by Kaleb
KEITHLEY

--- Additional comment from Worker Ant on 2018-01-24 05:22:45 EST ---

COMMIT: https://review.gluster.org/19235 committed in master by \"Kaleb
KEITHLEY\" <kkeithle at redhat.com> with a commit message- build: glibc has
removed rpc headers and rpcgen in Fedora28, use libtirpc

Other Linux distributions are doing the same; some others have already
done so.

Switch to libtirpc(-devel) and unbundled rpcgen packages. For now
rpcgen is still provided by the glibc-rpcgen RPM, but rpcsvc-proto's
rpcgen subpackage is available now but will not be used until
glibc-rpcgen is retired. (note, rpcsvc-proto's rpcgen is just named
rpcgen-...rpm. I.e. not rpcsvc-proto-rpcgen.) Right now either one
will satisfy the BuildRequires: rpcgen.

Also, when a .spec file has
  BuildRequires: foo-devel
it is not necessary to also have:
  BuildRequires: foo
or even:
  BuildRequires: foo foo-devel

The foo-devel package has a dependency on foo, which will install foo
automatically. It's usually also not necessary to have a corresponding
  Requires: foo
as the rpmbuild process will also automatically determine the
install-time dependencies.

And other minor glusterfs.spec.in cleanup of ipv6-default, including
sorting the argument definitions because the comment says "keep them
sorted" (Though nobody appears to have ever sorted them in the first
place.)

Change-Id: I86f847dfda0fef83e22c6e8b761342d652a2d9ba
BUG: 1536186
Signed-off-by: Kaleb S. KEITHLEY <kkeithle at redhat.com>

--- Additional comment from Worker Ant on 2018-01-24 05:48:01 EST ---

REVIEW: https://review.gluster.org/19311 (build: use libtirpc by default, even
if ipv6 is not the default) posted (#1) for review on master by Niels de Vos

--- Additional comment from Worker Ant on 2018-01-24 12:17:31 EST ---

COMMIT: https://review.gluster.org/19311 committed in master by \"Niels de
Vos\" <ndevos at redhat.com> with a commit message- build: use libtirpc by
default, even if ipv6 is not the default

An error sneaked in with Change-Id I86f847dfd. The check for requiring
libtirpc-devel should be done regardless of the ipv6-default. Even if
IPv6 is not the default, libtirpc-devel should be used unless it is
explicitly requested by a --without option.

libtirpc can not be used on EL6 and EL7 yet. The EL7 version does not
provide xdr_sizeof(), in addition to that, EL6 does not have
xdr_uint32_t() and xdr_uint64_t().

BUG: 1536186
Change-Id: I4a8292de2eddad16137df5998334133fc1e11261
Fixes: 0c57232ae07f48bd6483bfe88a182f832377ef52
Signed-off-by: Niels de Vos <ndevos at redhat.com>

--- Additional comment from Worker Ant on 2018-01-25 04:21:15 EST ---

REVIEW: https://review.gluster.org/19324 (build: Remove unwanted autoconf
messages for libtirpc) posted (#1) for review on master by Anoop C S

--- Additional comment from Worker Ant on 2018-01-25 10:51:21 EST ---

REVIEW: https://review.gluster.org/19330 (build: use libtirpc by default, even
if ipv6 is not the default) posted (#1) for review on master by Kaleb KEITHLEY


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1536186
[Bug 1536186] build: glibc has removed legacy rpc headers and rpcgen in
Fedora28, use libtirpc
https://bugzilla.redhat.com/show_bug.cgi?id=1536187
[Bug 1536187] build: glibc has removed legacy rpc headers and rpcgen in
Fedora28, use libtirpc
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.