[Bugs] [Bug 1507749] New: clean up port map on brick disconnect

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1507749

            Bug ID: 1507749
           Summary: clean up port map on brick disconnect
           Product: GlusterFS
           Version: 3.10
         Component: glusterd
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: bugs at gluster.org
        Depends On: 1503246
            Blocks: 1503244, 1507747



+++ This bug was initially created as a clone of Bug #1503246 +++

Description of problem:

GlusterD's portmap entry for a brick is cleaned up when a PMAP_SIGNOUT event is
initiated by the brick process at the shutdown. But if the brick process
crashes or gets killed through SIGKILL then this event is not initiated and
glusterd ends up with a stale port. Since GlusterD's portmap traversal happens
both ways, forward for allocation and backward for registry search, there is a
possibility that glusterd might end up running with a stale port for a brick
which eventually will end up with clients to fail to connect to the bricks or
other daemons.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-10-17 12:07:18 EDT ---

REVIEW: https://review.gluster.org/18541 (glusterd: clean up portmap on brick
disconnect) posted (#1) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Worker Ant on 2017-10-19 09:43:56 EDT ---

REVIEW: https://review.gluster.org/18541 (glusterd: clean up portmap on brick
disconnect) posted (#2) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Worker Ant on 2017-10-31 00:37:16 EDT ---

COMMIT: https://review.gluster.org/18541 committed in master by  

------------- glusterd: clean up portmap on brick disconnect

GlusterD's portmap entry for a brick is cleaned up when a PMAP_SIGNOUT event is
initiated by the brick process at the shutdown. But if the brick process
crashes
or gets killed through SIGKILL then this event is not initiated and glusterd
ends up with a stale port. Since GlusterD's portmap traversal happens both
ways,
forward for allocation and backward for registry search, there is a possibility
that glusterd might end up running with a stale port for a brick which
eventually will end up with clients to fail to connect to the bricks.

Solution is to clean up the port entry in case the process is down as
part of the brick disconnect event. Although with this the handling
PMAP_SIGNOUT event becomes redundant in most of the cases, but this is
the safeguard method to avoid glusterd getting into the stale port
issues.

Change-Id: I04c5be6d11e772ee4de16caf56dbb37d5c944303
BUG: 1503246
Signed-off-by: Atin Mukherjee <amukherj at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1503244
[Bug 1503244] socket poller error in glusterd logs
https://bugzilla.redhat.com/show_bug.cgi?id=1503246
[Bug 1503246] clean up port map on brick disconnect
https://bugzilla.redhat.com/show_bug.cgi?id=1507747
[Bug 1507747] clean up port map on brick disconnect
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.