[Bugs] [Bug 1505370] Mishandling null check at send_brick_req of glusterfsd/src/ gf_attach.c

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 25 11:46:43 UTC 2017


--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/18556 committed in release-3.12 by jiffin
tony Thottan (jthottan at redhat.com) 
commit 23c7a47f6b65005ed78086b176e0ca7b42494467
Author: Sanju Rakonde <srakonde at redhat.com>
Date:   Wed Oct 18 08:06:24 2017 +0530

    glusterfsd: Dereferencing the null pointer

    Problem: When control reaches to out, one of (iobref, iobuf, frame) can
    be null.for iobref, iobuf iobref_unref() and iobuf_unref() functions
    are called respectively, which are using GF_VALIDATE_OR_GOTO(), so
    there won't be null pointer dereference. But for frame without null
    checking STACK_DESTROY(frame->root) is called causing null pointer

    Fix: adding a line for null checking, the function
    STACK_DESTROY(frame->root) is called only when frame is not null.

    Change-Id: I3a6684c11fb7b694b81d6ad4fec3bced5562ad88
    BUG: 1505370
    Signed-off-by: Sanju Rakonde <srakonde at redhat.com>
    (cherry picked from commit 87bd25b64ae34cce95e87e724acfeab4c13d60a4)

You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

More information about the Bugs mailing list