[Bugs] [Bug 1502928] New: Mishandling null check at send_brick_req of glusterfsd/ src/gf_attach.c

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 17 04:20:29 UTC 2017


            Bug ID: 1502928
           Summary: Mishandling null check at send_brick_req of
           Product: GlusterFS
           Version: 3.10
         Component: glusterd
          Severity: low
          Assignee: bugs at gluster.org
          Reporter: alexc at sbrella.com
                CC: bugs at gluster.org

Description of problem:

There are three of `goto out` at `send_brick_req`

        iobuf = iobuf_get2 (rpc->ctx->iobuf_pool, req_size);
        if (!iobuf)
                goto out;

        iobref = iobref_new ();
        if (!iobref)
                goto out;

        frame = create_frame (this, this->ctx->pool);
        if (!frame)
                goto out;

that indicates the three of them (iobuf, iobref, frame) might be null and then
jumps to label `out`.

but there might be null pointer dereference after label out:
        iobref_unref (iobref);
        iobuf_unref (iobuf);
        STACK_DESTROY (frame->root);

the error handling code might not work as expected.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:

Actual results:

Expected results:

Additional info:

You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

More information about the Bugs mailing list