[Bugs] [Bug 1495162] glusterd ends up with multiple uuids for the same node

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1495162



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/18381 committed in release-3.12 by jiffin
tony Thottan (jthottan at redhat.com) 
------
commit 75ba5426232cbdbac87f74725a468bb4c9b956f0
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Thu Sep 21 14:05:35 2017 +0530

    glusterd: retrieve uuid under mutex lock

    In a multi node cluster, if one of the glusterd instance goes down and
    comes back, then there might be a race situation where glusterd needs to
    retrieve its uuid (glusterd_retrieve_uuid) and at the same time as part of
    receiving a friend handshake from other peer, glusterd iterates over the
volume
    information recieved from remote node and checks for if a brick is local or
not
    by calling MY_UUID which in turn calls glusterd_retrieve_uuid. And the
    same applies for glusterd_store_global_info () function too. This
    could end up in a situation where for the same node glusterd ends up
    generating two UUID files in /var/lib/glusterd. Following is the log
    snippet which confirms the above:

    [2017-09-01 03:09:24.458030] I [glusterd.c:146:glusterd_uuid_init]
0-management: retrieved UUID: fd46a495-7e33-468f-88f6-63c815fac640  // thread 1
retrieve uuid from glusterd.info
    [2017-09-01 03:09:24.458034] E
[glusterd-store.c:2109:glusterd_retrieve_uuid] 0-: No previous uuid is present
    //thread 2 can not retrieve uuid, because in thread1 the file pointer has
already become eof.
    [2017-09-01 03:09:24.458041] E
[glusterd-store.c:2117:glusterd_retrieve_uuid] 0-: Returning -1
    [2017-09-01 03:09:24.458076] I [glusterd.c:176:glusterd_uuid_generate_save]
0-management: generated UUID: 190bb292-a296-4125-96da-42b247511cc4
    [2017-09-01 03:09:24.458129] E [store.c:367:gf_store_save_value] 0-: Able
to store key: UUID,value: 190bb292-a296-4125-96da-42b247511cc4

    Fix is to retrieve the uuid under mutex lock.

    Credits : cynthia.zhou at nokia-sbell.com

    > Reviewed-on: : https://review.gluster.org/#/c/18333/
    >(cherry picked from commit 898f0b7ce31ddf8ec02e572c5d22eff2e4205b4c)

    Change-Id: Ib9a5e159c3febf2aef13aa5e38f0a51fe409dadb
    BUG: 1495162
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uHaesCH6mq&a=cc_unsubscribe