[Bugs] [Bug 1515051] New: bug-1247563.t is failing on master

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1515051

            Bug ID: 1515051
           Summary: bug-1247563.t is failing on master
           Product: Red Hat Gluster Storage
           Version: 3.4
         Component: distribute
          Assignee: nbalacha at redhat.com
          Reporter: nbalacha at redhat.com
        QA Contact: tdesala at redhat.com
                CC: bugs at gluster.org, nbalacha at redhat.com,
                    ravishankar at redhat.com, rhs-bugs at redhat.com,
                    storage-qa-internal at redhat.com
        Depends On: 1514329
            Blocks: 1515042, 1515045



+++ This bug was initially created as a clone of Bug #1514329 +++

Description of problem:
Please see
http://lists.gluster.org/pipermail/maintainers/2017-November/003617.html

--- Additional comment from Nithya Balachandran on 2017-11-17 01:10:27 EST ---

On running prove -fv tests/bugs/distribute/bug-1247563.t:

On my system:


getfacl: Removing leading '/' from absolute path names
# file: bricks/brick1/backends/patchy3/dir1/FILE2
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a756e6c6162656c65645f743a733000
trusted.SGI_ACL_FILE=0x0000000500000001ffffffff0006000000000002000000000007000000000004ffffffff0004000000000010ffffffff0007000000000020ffffffff00040000
trusted.gfid=0xb597bb42e7bb4b4a91e464e1b536d6d7
trusted.gfid2path.7de510351b1c8e08=0x65393039386432382d346166612d343030372d396230322d3066316463313961666337312f46494c4532
trusted.glusterfs.dht.linkto=0x7061746368792d636c69656e742d3100
trusted.glusterfs.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a756e6c6162656c65645f743a733000


On Ravi's system where the issue is reproducible:


[root at ravi1 backends]# getfattr -e hex  -m . -d   ./patchy3/dir1/FILE2 ;
getfacl ./patchy3/dir1/FILE2 
# file: patchy3/dir1/FILE2
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a64656661756c745f743a733000
system.posix_acl_access=0x0200000001000600ffffffff020007000000000004000400ffffffff10000700ffffffff20000400ffffffff
trusted.SGI_ACL_FILE=0x0000000500000001ffffffff0006000000000002000000000007000000000004ffffffff0004000000000010ffffffff0007000000000020ffffffff00040000
trusted.gfid=0x4fa885df7204439293c32569310ee747
trusted.gfid2path.9db1d06b9f2b8b0a=0x30623737313037312d323435622d343134372d396233302d3463326466383363633639642f46494c4532
trusted.glusterfs.dht.linkto=0x7061746368792d636c69656e742d3100
trusted.glusterfs.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a64656661756c745f743a733000


There is an ACL (system.posix_acl_access)set on the file which causes the
following test to fail.

#The linkto file should not have any posix acls set                             
COUNT=`getfacl $FPATH2 |grep -c "user:root:rwx"`                                
EXPECT "0" echo $COUNT 


>From Google:

..."the XFS filesystem which stores ACLs  as trusted.SGI_ACL_FILE extended 
attribute and generates system.posix_acl_access on the fly."


Assuming that this is not an attribute the user space should set on a file, I
am stripping this out from the results of the listxattr call in
dht_migrate_file.

--- Additional comment from Worker Ant on 2017-11-17 01:45:31 EST ---

REVIEW: https://review.gluster.org/18794 (cluster/dht: Don't set ACLs on linkto
file) posted (#1) for review on master by N Balachandran

--- Additional comment from Worker Ant on 2017-11-18 22:06:43 EST ---

COMMIT: https://review.gluster.org/18794 committed in master by \"N
Balachandran\" <nbalacha at redhat.com> with a commit message- cluster/dht: Don't
set ACLs on linkto file

The trusted.SGI_ACL_FILE appears to set posix
ACLs on the linkto file that is a target of
file migration. This can mess up file permissions
and cause linkto identification to fail.
Now we remove all ACL xattrs from the results of
the listxattr call on the source before setting them
on the target.

Change-Id: I56802dbaed783a16e3fb90f59f4ce849f8a4a9b4
BUG: 1514329
Signed-off-by: N Balachandran <nbalacha at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1514329
[Bug 1514329] bug-1247563.t is failing on master
https://bugzilla.redhat.com/show_bug.cgi?id=1515042
[Bug 1515042] bug-1247563.t is failing on master
https://bugzilla.redhat.com/show_bug.cgi?id=1515045
[Bug 1515045] bug-1247563.t is failing on master
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=djGLQDplCm&a=cc_unsubscribe