[Bugs] [Bug 1509833] New: [Disperse] : Improve heal info command to handle obvious cases

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1509833

            Bug ID: 1509833
           Summary: [Disperse] : Improve heal info command to handle
                    obvious cases
           Product: Red Hat Gluster Storage
           Version: 3.4
         Component: disperse
          Severity: medium
          Priority: high
          Assignee: aspandey at redhat.com
          Reporter: sheggodu at redhat.com
        QA Contact: nchilaka at redhat.com
                CC: aspandey at redhat.com, bugs at gluster.org,
                    pkarampu at redhat.com, rhs-bugs at redhat.com,
                    sheggodu at redhat.com, storage-qa-internal at redhat.com
        Depends On: 1476668



+++ This bug was initially created as a clone of Bug #1476668 +++

Description of problem:

If an update fop (data) is going on for a file, its index entry will be present
in .glustrfs/indeices.
Now, If a brick is down and we run heal info on EC volume, it is obvious that
this file needs heal. There is no need of taking lock and slowing down heal
info command.



Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-07-31 03:44:23 EDT ---

REVIEW: https://review.gluster.org/17923 (cluster/ec: Improve heal info command
to handle obvious cases) posted (#1) for review on master by Ashish Pandey
(aspandey at redhat.com)

--- Additional comment from Worker Ant on 2017-10-09 13:20:42 EDT ---

REVIEW: https://review.gluster.org/17923 (cluster/ec: Improve heal info command
to handle obvious cases) posted (#2) for review on master by Ashish Pandey
(aspandey at redhat.com)

--- Additional comment from Worker Ant on 2017-10-11 06:27:54 EDT ---

REVIEW: https://review.gluster.org/17923 (cluster/ec: Improve heal info command
to handle obvious cases) posted (#3) for review on master by Ashish Pandey
(aspandey at redhat.com)

--- Additional comment from Worker Ant on 2017-10-15 22:40:05 EDT ---

COMMIT: https://review.gluster.org/17923 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit d88be3bc29dbd1eaa393802f3c98e188fe5287c8
Author: Ashish Pandey <aspandey at redhat.com>
Date:   Mon Jul 31 12:45:21 2017 +0530

    cluster/ec: Improve heal info command to handle obvious cases

    Problem:
    1 - If a brick is down and we see an index entry in
    .glusterfs/indices, we should show it in heal info
    output as it most certainly needs heal.

    2 - The first problem is also not getting handled after
    ec_heal_inspect. Even if in ec_heal_inspect, lookup will
    mark need_heal as true, we don't handle it properly in
    ec_get_heal_info and continue with locked inspect which
    takes lot of time.

    Solution:
    1 - In first case we need not to do any further invstigation.
    As soon as we see that a brick is down, we should say that
    this index entry needs heal for sure.

    2 - In second case, if we have need_heal as _gf_true after
    ec_heal_inspect, we should show it as heal requires.

    Change-Id: Ibe7f9d7602cc0b382ba53bddaf75a2a2c3326aa6
    BUG: 1476668
    Signed-off-by: Ashish Pandey <aspandey at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1476668
[Bug 1476668] [Disperse] : Improve heal info command to handle obvious
cases
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CJAz1RajF2&a=cc_unsubscribe