[Bugs] [Bug 1509200] New: Event webhook should work with HTTPS urls

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1509200

            Bug ID: 1509200
           Summary: Event webhook should work with HTTPS urls
           Product: GlusterFS
           Version: 3.12
         Component: eventsapi
          Severity: medium
          Priority: high
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
                CC: amukherj at redhat.com, rhs-bugs at redhat.com,
                    sabose at redhat.com, sanandpa at redhat.com,
                    sasundar at redhat.com
        Depends On: 1466122, 1506903



+++ This bug was initially created as a clone of Bug #1506903 +++

+++ This bug was initially created as a clone of Bug #1466122 +++

Description of problem:

While integrating gluster with oVirt, an HTTPS url was used to register the
webhook with gluster-events.

The webhook test fails with error:
NOT OK: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:579)



Version-Release number of selected component (if applicable):


How reproducible:
Always

--- Additional comment from Worker Ant on 2017-10-27 02:56:08 EDT ---

REVIEW: https://review.gluster.org/18578 (eventsapi: HTTPS support for
Webhooks) posted (#1) for review on master by Aravinda VK (avishwan at redhat.com)

--- Additional comment from Worker Ant on 2017-10-30 07:07:17 EDT ---

REVIEW: https://review.gluster.org/18578 (eventsapi: HTTPS support for
Webhooks) posted (#1) for review on master by Aravinda VK

--- Additional comment from Worker Ant on 2017-10-31 02:47:35 EDT ---

COMMIT: https://review.gluster.org/18578 committed in master by  

------------- eventsapi: HTTPS support for Webhooks

First it tries to call URL with verify=True without specifying the cert
path, it succeeds if a webhook is HTTP or HTTPS with CA trusted
certificates(for example https://github..).

If above call fails with SSL error then it tries to get the server
certificate and calls URL again. If call fails with SSL error even after
using the certificate, then verification will be disabled and logged in
the log file.

All other errors will be catched and logged as usual.

BUG: 1506903
Change-Id: I86a3390ed48b75dffdc7848022af23a1e1d7f076
Signed-off-by: Aravinda VK <avishwan at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1466122
[Bug 1466122] Event webhook should work with HTTPS urls
https://bugzilla.redhat.com/show_bug.cgi?id=1506903
[Bug 1506903] Event webhook should work with HTTPS urls
-- 
You are receiving this mail because:
You are the assignee for the bug.