[Bugs] [Bug 1456582] "split-brain observed [Input/output error]" error messages in samba logs during parallel rm -rf

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1456582



--- Comment #5 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17414 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit de92c363c95d16966dbcc9d8763fd4448dd84d13
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Mon May 29 21:38:14 2017 +0530

    posix: use the correct op_errno

    Problem:
    If readdir/fstat was performed on a directory that was removed,
    posix_fd_ctx_get() fails with ENOENT but we incorrectly use the ret
    value (-1 in this case) as op_errno, logging "Operation not permitted"
    messages in the brick logs. Also in case of fstat, the -1 op_errno was
    also propagated to the client via stack unwind, causing the message to
    appear in protocol/client logs as well.

    Fix:
    Use the right op_errno in readdir, fstat and writev. Also, if
    posix_fd_ctx_get() failed with ENOENT, convert it into EBADF because
    ENOENT is not a valid error for an fd operation.

    Change-Id: Ie43c0789d5040ec73b7cf885d015a183b8c64d70
    BUG: 1456582
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: https://review.gluster.org/17414
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Amar Tumballi <amarts at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mSRg8NeKiE&a=cc_unsubscribe